You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Reser <be...@reser.org> on 2004/03/10 09:02:48 UTC
[PATCH] Add --version to svnversion, svndumpfilter, and svnserve
[[[
Add --version option to svndumpfilter, svnserve, and svnversion.
Also minor formating changes to svnversion's usage output to be
more consistent with other commands.
Patch by Ben Reser <be...@reser.org>
* subversion/svndumpfilter/main.c
Add svndumpfilter__quiet to the option enum.
(options_table): Add version option.
(cmd_table): Add version option to help command.
(svndumpfilter_opt_state): Add version boolean.
(subcommand_help): Support asking for the version output.
(main): Set help and version option states for version option.
* subversion/svnserve/main.c
Add SVNSERVE_OPT_VERSION constant.
(svnserve__options): Add version option.
(version): New function to wrap version output.
(main): Call version when --version is passed.
* subversion/svnversion/main.c
Add include for svn_opt.h
Add SVNVERSION_OPT_VERSION constant.
(version): New funciton to wrap version output.
(usage): Match output of other commands more closely and use
svn_opt_format_option. Add a pool paramter.
(main) Add version option. usage needs a pool paramter now.
]]]
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
Re: [PATCH] Add --version to svnversion, svndumpfilter, and svnserve
Posted by Julian Foad <ju...@btopenworld.com>.
Justin Erenkrantz wrote:
> --On Wednesday, March 10, 2004 1:02 AM -0800 Ben Reser <be...@reser.org>
> wrote:
>
Good thing to do.
While you're fixing the log message...
>> [[[
>> Add --version option to svndumpfilter, svnserve, and svnversion.
>> Also minor formating changes to svnversion's usage output to be
"formatting"
>> more consistent with other commands.
>>
>> Patch by Ben Reser <be...@reser.org>
>>
>> * subversion/svndumpfilter/main.c
>> Add svndumpfilter__quiet to the option enum.
>
> This should be svndumpfilter__version. (I think Sussman's already
> pointed this out in IRC.)
>
>> (options_table): Add version option.
>> (cmd_table): Add version option to help command.
>> (svndumpfilter_opt_state): Add version boolean.
>> (subcommand_help): Support asking for the version output.
>> (main): Set help and version option states for version option.
>>
>> * subversion/svnserve/main.c
>> Add SVNSERVE_OPT_VERSION constant.
>> (svnserve__options): Add version option.
>> (version): New function to wrap version output.
>> (main): Call version when --version is passed.
>>
>> * subversion/svnversion/main.c
>> Add include for svn_opt.h
>> Add SVNVERSION_OPT_VERSION constant.
>> (version): New funciton to wrap version output.
"function"
>> (usage): Match output of other commands more closely and use
>> svn_opt_format_option. Add a pool paramter.
"parameter"
>> (main) Add version option. usage needs a pool paramter now.
"parameter"
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Add --version to svnversion, svndumpfilter, and svnserve
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Wednesday, March 10, 2004 1:02 AM -0800 Ben Reser <be...@reser.org> wrote:
> [[[
> Add --version option to svndumpfilter, svnserve, and svnversion.
> Also minor formating changes to svnversion's usage output to be
> more consistent with other commands.
>
> Patch by Ben Reser <be...@reser.org>
>
> * subversion/svndumpfilter/main.c
> Add svndumpfilter__quiet to the option enum.
This should be svndumpfilter__version. (I think Sussman's already pointed
this out in IRC.)
> (options_table): Add version option.
> (cmd_table): Add version option to help command.
> (svndumpfilter_opt_state): Add version boolean.
> (subcommand_help): Support asking for the version output.
> (main): Set help and version option states for version option.
>
> * subversion/svnserve/main.c
> Add SVNSERVE_OPT_VERSION constant.
> (svnserve__options): Add version option.
> (version): New function to wrap version output.
> (main): Call version when --version is passed.
>
> * subversion/svnversion/main.c
> Add include for svn_opt.h
> Add SVNVERSION_OPT_VERSION constant.
> (version): New funciton to wrap version output.
> (usage): Match output of other commands more closely and use
> svn_opt_format_option. Add a pool paramter.
> (main) Add version option. usage needs a pool paramter now.
>
> ]]]
Anyhoo, looks fine here. +1. -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org