You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/04/18 21:31:17 UTC
[GitHub] [jena] afs opened a new pull request #729: JENA-1884: remove UUID
afs opened a new pull request #729: JENA-1884: remove UUID
URL: https://github.com/apache/jena/pull/729
And JENA-1885.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a change in pull request #729: JENA-1884:
remove JenaUUID
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #729: JENA-1884: remove JenaUUID
URL: https://github.com/apache/jena/pull/729#discussion_r410769395
##########
File path: jena-base/src/main/java/org/apache/jena/atlas/lib/BitsLong.java
##########
@@ -157,22 +157,35 @@ boolean test(long bits, long value, int start, int finish)
* @param start
* @param finish
* @return lon */
-
+
public static final
long access(long bits, int start, int finish)
{
check(start, finish) ;
- return access$(bits, start, finish) ;
+ return access$(bits, start, finish) ;
}
-
+
+ /**
+ * Clear the bit specified.
+ * @param bits
+ * @param bitIndex
+ * @return long
+ */
+ public static final
+ long clear(long bits, int bitIndex)
+ {
+ check(bitIndex) ;
Review comment:
Ditto above about `check` in `clear$`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a change in pull request #729: JENA-1884:
remove JenaUUID
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #729: JENA-1884: remove JenaUUID
URL: https://github.com/apache/jena/pull/729#discussion_r410769237
##########
File path: jena-base/src/main/java/org/apache/jena/atlas/lib/BitsInt.java
##########
@@ -155,14 +155,27 @@ boolean test(int bits, int value, int start, int finish)
* @param finish
* @return int
*/
-
+
public static final
int access(int bits, int start, int finish)
{
check(start, finish) ;
- return access$(bits, start, finish) ;
+ return access$(bits, start, finish) ;
+ }
+
+ /**
+ * Clear the bit specified.
+ * @param bits
+ * @param bitIndex
+ * @return int
+ */
+ public static final
+ int clear(int bits, int bitIndex)
+ {
+ check(bitIndex);
+ return clear$(bits, bitIndex) ;
Review comment:
`clear$` already does the `check(bitIndex)`. Would it be better to have it only there, or is it better to be safe and perform that verification on both methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #729: JENA-1884:
remove JenaUUID
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #729: JENA-1884: remove JenaUUID
URL: https://github.com/apache/jena/pull/729#discussion_r410849730
##########
File path: jena-base/src/main/java/org/apache/jena/atlas/lib/BitsLong.java
##########
@@ -157,22 +157,35 @@ boolean test(long bits, long value, int start, int finish)
* @param start
* @param finish
* @return lon */
-
+
public static final
long access(long bits, int start, int finish)
{
check(start, finish) ;
- return access$(bits, start, finish) ;
+ return access$(bits, start, finish) ;
}
-
+
+ /**
+ * Clear the bit specified.
+ * @param bits
+ * @param bitIndex
+ * @return long
+ */
+ public static final
+ long clear(long bits, int bitIndex)
+ {
+ check(bitIndex) ;
Review comment:
Can't find that one but what I have done is make the files exactly the same except s/int/long/. They now line up in diff and (easier to see!) line length.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #729: JENA-1884:
remove JenaUUID
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #729: JENA-1884: remove JenaUUID
URL: https://github.com/apache/jena/pull/729#discussion_r410849724
##########
File path: jena-base/src/main/java/org/apache/jena/atlas/lib/BitsInt.java
##########
@@ -155,14 +155,27 @@ boolean test(int bits, int value, int start, int finish)
* @param finish
* @return int
*/
-
+
public static final
int access(int bits, int start, int finish)
{
check(start, finish) ;
- return access$(bits, start, finish) ;
+ return access$(bits, start, finish) ;
+ }
+
+ /**
+ * Clear the bit specified.
+ * @param bits
+ * @param bitIndex
+ * @return int
+ */
+ public static final
+ int clear(int bits, int bitIndex)
+ {
+ check(bitIndex);
+ return clear$(bits, bitIndex) ;
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org