You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Xinyu Liu <xi...@gmail.com> on 2016/07/15 01:00:32 UTC
Review Request 50056: Multithreading changes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50056/
-----------------------------------------------------------
Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data Infrastructure).
Repository: samza
Description
-------
Squash the commmits into a single patch, including:
rb 48243: SAMZA-961: Async tasks and multithreading model
rb 48213: SAMZA-960: Make system producer thread safe
rb 48182: SAMZA-958: Make store/cache thread safe
Diffs
-----
checkstyle/import-control.xml 325c38131047836dc8aedaea4187598ef3ba7666
samza-api/src/main/java/org/apache/samza/task/AsyncStreamTask.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/task/TaskCallback.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/AsyncStreamTaskAdapter.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/CoordinatorRequests.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackImpl.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackListener.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackTimeoutException.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/util/Utils.java PRE-CREATION
samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 00648e49f8c7a9bbf5634e18ba0f95feb244613e
samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 49b08f6b68dbb44757dcc8ce8d60c365a9d22981
samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 08a4debb06f9925ae741049abb2ee0df97b2243b
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala cf05c15c836ddfa54ba8fe27abc18ed88ac5fc11
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 18c09224bbae959342daf9b2b7a7d971cc224f48
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala 2044ce01ffded8434e762d99355d5df43642c66b
samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala d32a92976e43ca24033b48c91851ee706de7de6b
samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala 8b863887cf584d2d7a9b18181c7b0cd1e9dfec00
samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala d3bd9b7c11afd44ccfb681b660fefffafd216c29
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 2efe836fc3b622cbe89e2042a37407f3cf732f58
samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestAsyncStreamAdapter.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestCoordinatorRequests.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackImpl.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackManager.java PRE-CREATION
samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala e280daa9626757cb4d17c0c03eed923277230c3e
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 1358fdd8a386f5f81128ef871c72833d8cf11d86
samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 5457f0e05ae4d615b9c86f48a662c54b13828e78
samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b
samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemProducer.scala 1f4b5c46436e44b7c7cd1a49689c4f43f1f6ed1b
samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala 5e8cc65260b6961350c64ddc13b9807dca9099c5
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 3769e103616dc0f1fd869706cc086e24cd926c48
samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemProducerJava.java 04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d
samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 72f25a354eaa98e8df379d07d9cc8613dfafd13a
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 9b9b1f6e641d87f52ce4adc839798453a3395f65
samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala b7f1cdc4dbaeea2413cee2ad60d74528f3950513
samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala e7e4ede1cf6b98b2f10e8b748b79dfaae3fa8bc1
samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala 96eb5faf5c2a6f8b4271a5ed16e709015d78bab0
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala fd4e7624afced0df104d4a90539149197b93808b
Diff: https://reviews.apache.org/r/50056/diff/
Testing
-------
Tested in yarn.
Thanks,
Xinyu Liu
Re: Review Request 50056: SAMZA-863: Multithreading changes
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50056/#review142960
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On July 19, 2016, 6:38 p.m., Xinyu Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50056/
> -----------------------------------------------------------
>
> (Updated July 19, 2016, 6:38 p.m.)
>
>
> Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> Squash the commmits into a single patch, including:
>
> rb 48243: SAMZA-961: Async tasks and multithreading model
>
> rb 48213: SAMZA-960: Make system producer thread safe
>
> rb 48182: SAMZA-958: Make store/cache thread safe
>
> All the rbs above have been reviewed and shipped.
>
>
> Diffs
> -----
>
> checkstyle/import-control.xml 325c38131047836dc8aedaea4187598ef3ba7666
> samza-api/src/main/java/org/apache/samza/task/AsyncStreamTask.java PRE-CREATION
> samza-api/src/main/java/org/apache/samza/task/TaskCallback.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/task/AsyncStreamTaskAdapter.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/task/CoordinatorRequests.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/task/TaskCallbackFactory.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/task/TaskCallbackImpl.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/task/TaskCallbackListener.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/task/TaskCallbackTimeoutException.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/util/Utils.java PRE-CREATION
> samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 00648e49f8c7a9bbf5634e18ba0f95feb244613e
> samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 49b08f6b68dbb44757dcc8ce8d60c365a9d22981
> samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 08a4debb06f9925ae741049abb2ee0df97b2243b
> samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala cf05c15c836ddfa54ba8fe27abc18ed88ac5fc11
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 18c09224bbae959342daf9b2b7a7d971cc224f48
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala 2044ce01ffded8434e762d99355d5df43642c66b
> samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala d32a92976e43ca24033b48c91851ee706de7de6b
> samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala 8b863887cf584d2d7a9b18181c7b0cd1e9dfec00
> samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala d3bd9b7c11afd44ccfb681b660fefffafd216c29
> samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 2efe836fc3b622cbe89e2042a37407f3cf732f58
> samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/task/TestAsyncStreamAdapter.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/task/TestCoordinatorRequests.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackImpl.java PRE-CREATION
> samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackManager.java PRE-CREATION
> samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala e280daa9626757cb4d17c0c03eed923277230c3e
> samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 1358fdd8a386f5f81128ef871c72833d8cf11d86
> samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 5457f0e05ae4d615b9c86f48a662c54b13828e78
> samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b
> samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemProducer.scala 1f4b5c46436e44b7c7cd1a49689c4f43f1f6ed1b
> samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala 5e8cc65260b6961350c64ddc13b9807dca9099c5
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 3769e103616dc0f1fd869706cc086e24cd926c48
> samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemProducerJava.java 04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2
> samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d
> samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 72f25a354eaa98e8df379d07d9cc8613dfafd13a
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 9b9b1f6e641d87f52ce4adc839798453a3395f65
> samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala b7f1cdc4dbaeea2413cee2ad60d74528f3950513
> samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala e7e4ede1cf6b98b2f10e8b748b79dfaae3fa8bc1
> samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala 96eb5faf5c2a6f8b4271a5ed16e709015d78bab0
> samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala fd4e7624afced0df104d4a90539149197b93808b
>
> Diff: https://reviews.apache.org/r/50056/diff/
>
>
> Testing
> -------
>
> Tested in yarn.
>
>
> Thanks,
>
> Xinyu Liu
>
>
Re: Review Request 50056: SAMZA-863: Multithreading changes
Posted by Xinyu Liu <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50056/
-----------------------------------------------------------
(Updated July 19, 2016, 6:38 p.m.)
Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data Infrastructure).
Repository: samza
Description
-------
Squash the commmits into a single patch, including:
rb 48243: SAMZA-961: Async tasks and multithreading model
rb 48213: SAMZA-960: Make system producer thread safe
rb 48182: SAMZA-958: Make store/cache thread safe
All the rbs above have been reviewed and shipped.
Diffs (updated)
-----
checkstyle/import-control.xml 325c38131047836dc8aedaea4187598ef3ba7666
samza-api/src/main/java/org/apache/samza/task/AsyncStreamTask.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/task/TaskCallback.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/AsyncStreamTaskAdapter.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/CoordinatorRequests.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackImpl.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackListener.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackTimeoutException.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/util/Utils.java PRE-CREATION
samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 00648e49f8c7a9bbf5634e18ba0f95feb244613e
samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 49b08f6b68dbb44757dcc8ce8d60c365a9d22981
samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 08a4debb06f9925ae741049abb2ee0df97b2243b
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala cf05c15c836ddfa54ba8fe27abc18ed88ac5fc11
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 18c09224bbae959342daf9b2b7a7d971cc224f48
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala 2044ce01ffded8434e762d99355d5df43642c66b
samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala d32a92976e43ca24033b48c91851ee706de7de6b
samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala 8b863887cf584d2d7a9b18181c7b0cd1e9dfec00
samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala d3bd9b7c11afd44ccfb681b660fefffafd216c29
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 2efe836fc3b622cbe89e2042a37407f3cf732f58
samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestAsyncStreamAdapter.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestCoordinatorRequests.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackImpl.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackManager.java PRE-CREATION
samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala e280daa9626757cb4d17c0c03eed923277230c3e
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 1358fdd8a386f5f81128ef871c72833d8cf11d86
samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 5457f0e05ae4d615b9c86f48a662c54b13828e78
samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b
samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemProducer.scala 1f4b5c46436e44b7c7cd1a49689c4f43f1f6ed1b
samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala 5e8cc65260b6961350c64ddc13b9807dca9099c5
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 3769e103616dc0f1fd869706cc086e24cd926c48
samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemProducerJava.java 04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d
samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 72f25a354eaa98e8df379d07d9cc8613dfafd13a
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 9b9b1f6e641d87f52ce4adc839798453a3395f65
samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala b7f1cdc4dbaeea2413cee2ad60d74528f3950513
samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala e7e4ede1cf6b98b2f10e8b748b79dfaae3fa8bc1
samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala 96eb5faf5c2a6f8b4271a5ed16e709015d78bab0
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala fd4e7624afced0df104d4a90539149197b93808b
Diff: https://reviews.apache.org/r/50056/diff/
Testing
-------
Tested in yarn.
Thanks,
Xinyu Liu
Re: Review Request 50056: SAMZA-863: Multithreading changes
Posted by Xinyu Liu <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50056/
-----------------------------------------------------------
(Updated July 18, 2016, 6:15 p.m.)
Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data Infrastructure).
Repository: samza
Description (updated)
-------
Squash the commmits into a single patch, including:
rb 48243: SAMZA-961: Async tasks and multithreading model
rb 48213: SAMZA-960: Make system producer thread safe
rb 48182: SAMZA-958: Make store/cache thread safe
All the rbs above have been reviewed and shipped.
Diffs
-----
checkstyle/import-control.xml 325c38131047836dc8aedaea4187598ef3ba7666
samza-api/src/main/java/org/apache/samza/task/AsyncStreamTask.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/task/TaskCallback.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/AsyncStreamTaskAdapter.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/CoordinatorRequests.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackImpl.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackListener.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackTimeoutException.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/util/Utils.java PRE-CREATION
samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 00648e49f8c7a9bbf5634e18ba0f95feb244613e
samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 49b08f6b68dbb44757dcc8ce8d60c365a9d22981
samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 08a4debb06f9925ae741049abb2ee0df97b2243b
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala cf05c15c836ddfa54ba8fe27abc18ed88ac5fc11
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 18c09224bbae959342daf9b2b7a7d971cc224f48
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala 2044ce01ffded8434e762d99355d5df43642c66b
samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala d32a92976e43ca24033b48c91851ee706de7de6b
samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala 8b863887cf584d2d7a9b18181c7b0cd1e9dfec00
samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala d3bd9b7c11afd44ccfb681b660fefffafd216c29
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 2efe836fc3b622cbe89e2042a37407f3cf732f58
samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestAsyncStreamAdapter.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestCoordinatorRequests.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackImpl.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackManager.java PRE-CREATION
samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala e280daa9626757cb4d17c0c03eed923277230c3e
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 1358fdd8a386f5f81128ef871c72833d8cf11d86
samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 5457f0e05ae4d615b9c86f48a662c54b13828e78
samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b
samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemProducer.scala 1f4b5c46436e44b7c7cd1a49689c4f43f1f6ed1b
samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala 5e8cc65260b6961350c64ddc13b9807dca9099c5
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 3769e103616dc0f1fd869706cc086e24cd926c48
samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemProducerJava.java 04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d
samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 72f25a354eaa98e8df379d07d9cc8613dfafd13a
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 9b9b1f6e641d87f52ce4adc839798453a3395f65
samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala b7f1cdc4dbaeea2413cee2ad60d74528f3950513
samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala e7e4ede1cf6b98b2f10e8b748b79dfaae3fa8bc1
samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala 96eb5faf5c2a6f8b4271a5ed16e709015d78bab0
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala fd4e7624afced0df104d4a90539149197b93808b
Diff: https://reviews.apache.org/r/50056/diff/
Testing
-------
Tested in yarn.
Thanks,
Xinyu Liu
Re: Review Request 50056: SAMZA-863: Multithreading changes
Posted by Xinyu Liu <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50056/
-----------------------------------------------------------
(Updated July 18, 2016, 6:14 p.m.)
Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data Infrastructure).
Summary (updated)
-----------------
SAMZA-863: Multithreading changes
Repository: samza
Description
-------
Squash the commmits into a single patch, including:
rb 48243: SAMZA-961: Async tasks and multithreading model
rb 48213: SAMZA-960: Make system producer thread safe
rb 48182: SAMZA-958: Make store/cache thread safe
Diffs
-----
checkstyle/import-control.xml 325c38131047836dc8aedaea4187598ef3ba7666
samza-api/src/main/java/org/apache/samza/task/AsyncStreamTask.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/task/TaskCallback.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/AsyncStreamTaskAdapter.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/CoordinatorRequests.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackImpl.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackListener.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackTimeoutException.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/util/Utils.java PRE-CREATION
samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 00648e49f8c7a9bbf5634e18ba0f95feb244613e
samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 49b08f6b68dbb44757dcc8ce8d60c365a9d22981
samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 08a4debb06f9925ae741049abb2ee0df97b2243b
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala cf05c15c836ddfa54ba8fe27abc18ed88ac5fc11
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 18c09224bbae959342daf9b2b7a7d971cc224f48
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala 2044ce01ffded8434e762d99355d5df43642c66b
samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala d32a92976e43ca24033b48c91851ee706de7de6b
samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala 8b863887cf584d2d7a9b18181c7b0cd1e9dfec00
samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala d3bd9b7c11afd44ccfb681b660fefffafd216c29
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 2efe836fc3b622cbe89e2042a37407f3cf732f58
samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestAsyncStreamAdapter.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestCoordinatorRequests.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackImpl.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackManager.java PRE-CREATION
samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala e280daa9626757cb4d17c0c03eed923277230c3e
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 1358fdd8a386f5f81128ef871c72833d8cf11d86
samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 5457f0e05ae4d615b9c86f48a662c54b13828e78
samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b
samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemProducer.scala 1f4b5c46436e44b7c7cd1a49689c4f43f1f6ed1b
samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala 5e8cc65260b6961350c64ddc13b9807dca9099c5
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 3769e103616dc0f1fd869706cc086e24cd926c48
samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemProducerJava.java 04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d
samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 72f25a354eaa98e8df379d07d9cc8613dfafd13a
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 9b9b1f6e641d87f52ce4adc839798453a3395f65
samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala b7f1cdc4dbaeea2413cee2ad60d74528f3950513
samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala e7e4ede1cf6b98b2f10e8b748b79dfaae3fa8bc1
samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala 96eb5faf5c2a6f8b4271a5ed16e709015d78bab0
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala fd4e7624afced0df104d4a90539149197b93808b
Diff: https://reviews.apache.org/r/50056/diff/
Testing
-------
Tested in yarn.
Thanks,
Xinyu Liu
Re: Review Request 50056: Multithreading changes
Posted by Xinyu Liu <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50056/
-----------------------------------------------------------
(Updated July 18, 2016, 6:13 p.m.)
Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data Infrastructure).
Changes
-------
Drop the changes for disk throttling in AsyncRunLoop. We will have a seperate patch for it. This patch is purely for adding multithreading support.
Repository: samza
Description
-------
Squash the commmits into a single patch, including:
rb 48243: SAMZA-961: Async tasks and multithreading model
rb 48213: SAMZA-960: Make system producer thread safe
rb 48182: SAMZA-958: Make store/cache thread safe
Diffs (updated)
-----
checkstyle/import-control.xml 325c38131047836dc8aedaea4187598ef3ba7666
samza-api/src/main/java/org/apache/samza/task/AsyncStreamTask.java PRE-CREATION
samza-api/src/main/java/org/apache/samza/task/TaskCallback.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/AsyncStreamTaskAdapter.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/CoordinatorRequests.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackFactory.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackImpl.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackListener.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/task/TaskCallbackTimeoutException.java PRE-CREATION
samza-core/src/main/java/org/apache/samza/util/Utils.java PRE-CREATION
samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 00648e49f8c7a9bbf5634e18ba0f95feb244613e
samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 49b08f6b68dbb44757dcc8ce8d60c365a9d22981
samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 08a4debb06f9925ae741049abb2ee0df97b2243b
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala cf05c15c836ddfa54ba8fe27abc18ed88ac5fc11
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 18c09224bbae959342daf9b2b7a7d971cc224f48
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala 2044ce01ffded8434e762d99355d5df43642c66b
samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala d32a92976e43ca24033b48c91851ee706de7de6b
samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala 8b863887cf584d2d7a9b18181c7b0cd1e9dfec00
samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala d3bd9b7c11afd44ccfb681b660fefffafd216c29
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala 2efe836fc3b622cbe89e2042a37407f3cf732f58
samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestAsyncStreamAdapter.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestCoordinatorRequests.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackImpl.java PRE-CREATION
samza-core/src/test/java/org/apache/samza/task/TestTaskCallbackManager.java PRE-CREATION
samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala e280daa9626757cb4d17c0c03eed923277230c3e
samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 1358fdd8a386f5f81128ef871c72833d8cf11d86
samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 5457f0e05ae4d615b9c86f48a662c54b13828e78
samza-core/src/test/scala/org/apache/samza/system/TestSystemConsumers.scala 09da62e0f9a10f7c3683345a309c6278ff01fb4b
samza-hdfs/src/main/scala/org/apache/samza/system/hdfs/HdfsSystemProducer.scala 1f4b5c46436e44b7c7cd1a49689c4f43f1f6ed1b
samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala 5e8cc65260b6961350c64ddc13b9807dca9099c5
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 3769e103616dc0f1fd869706cc086e24cd926c48
samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemProducerJava.java 04c9113fd6c3dd56c49ff46c8c1c0ff12f68e5e2
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala 8e32bba6ced090f0fc8d4e5176fe0788df36981d
samza-kv-inmemory/src/main/scala/org/apache/samza/storage/kv/inmemory/InMemoryKeyValueStore.scala 72f25a354eaa98e8df379d07d9cc8613dfafd13a
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala 9b9b1f6e641d87f52ce4adc839798453a3395f65
samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala b7f1cdc4dbaeea2413cee2ad60d74528f3950513
samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala e7e4ede1cf6b98b2f10e8b748b79dfaae3fa8bc1
samza-kv/src/test/scala/org/apache/samza/storage/kv/TestCachedStore.scala 96eb5faf5c2a6f8b4271a5ed16e709015d78bab0
samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala fd4e7624afced0df104d4a90539149197b93808b
Diff: https://reviews.apache.org/r/50056/diff/
Testing
-------
Tested in yarn.
Thanks,
Xinyu Liu