You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajastro (via GitHub)" <gi...@apache.org> on 2023/05/15 05:06:30 UTC
[GitHub] [airflow] pankajastro opened a new pull request, #31282: Make connection id validation consistent across interface
pankajastro opened a new pull request, #31282:
URL: https://github.com/apache/airflow/pull/31282
recently, we added the connection id validation
if the user creates a connection from UI but
this improvement is missing in CLI and API.
This PR make sure that connection id validation is consistent
across interfaces like CLI, API, and UI.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #31282: Make connection id validation consistent across interface
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #31282:
URL: https://github.com/apache/airflow/pull/31282#discussion_r1193495507
##########
airflow/cli/commands/connection_command.py:
##########
@@ -203,6 +203,12 @@ def connections_add(args):
has_json = bool(args.conn_json)
has_type = bool(args.conn_type)
+ # Validate connection-id
+ try:
+ helpers.validate_key(args.conn_id, max_length=200)
+ except Exception as e:
+ raise SystemExit(f"Could not create connection. {str(e)}")
Review Comment:
```suggestion
raise SystemExit(f"Could not create connection. {e}")
```
Same for similar string formatting code below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #31282: Make connection id validation consistent across interface
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #31282:
URL: https://github.com/apache/airflow/pull/31282#discussion_r1193495507
##########
airflow/cli/commands/connection_command.py:
##########
@@ -203,6 +203,12 @@ def connections_add(args):
has_json = bool(args.conn_json)
has_type = bool(args.conn_type)
+ # Validate connection-id
+ try:
+ helpers.validate_key(args.conn_id, max_length=200)
+ except Exception as e:
+ raise SystemExit(f"Could not create connection. {str(e)}")
Review Comment:
```suggestion
raise SystemExit(f"Could not create connection. {e}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #31282: Make connection id validation consistent across interface
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #31282:
URL: https://github.com/apache/airflow/pull/31282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org