[jira] [Comment Edited] (PHOENIX-5303) Fix index failures with some versions of HBase.

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850085#comment-16850085 ] 

Andrew Purtell edited comment on PHOENIX-5303 at 5/28/19 7:58 PM:
------------------------------------------------------------------

I commented elsewhere, the change is committed to all live branch-1s. Maybe the difference is due to 1.4.10 not being released yet with the change included, but 1.3 has it. And 1.5 will have it. Adding the OR condition is the right thing to do given that HBase has decided the earlier behavior was a bug. 
Edit: I also posted a followup with the committer about the report of an inconsistent application to branch-2. 


was (Author: apurtell):
I commented elsewhere, the change is committed to all live branch-1s. Maybe the difference is due to 1.4.10 not being released yet with the change included, but 1.3 has it. And 1.5 will have it. Adding the OR condition is the right thing to do given that HBase has decided the earlier behavior was a bug. 

> Fix index failures with some versions of HBase.
> -----------------------------------------------
>
>                 Key: PHOENIX-5303
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5303
>             Project: Phoenix
>          Issue Type: Test
>    Affects Versions: 4.15.0, 5.1.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Blocker
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: 5303.txt
>
>
> The problem was introduced with HBASE-21158. The fix here works regardless of the HBase version.
> This must have started very recently, but it's already past the history of the test runs.
> Or perhaps it never works in 4.x-HBase-1.5
> [~apurtell], in case you have any ideas.
> {code:java}
> [INFO] Running org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec
> [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.403 s <<< FAILURE! - in org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec
> [ERROR] testGeneratedIndexUpdates(org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec) Time elapsed: 0.16 s <<< FAILURE!
> java.lang.AssertionError: Had some index updates, though it should have been covered by the delete
> at org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec.ensureNoUpdatesWhenCoveredByDelete(TestCoveredColumnIndexCodec.java:242)
> at org.apache.phoenix.hbase.index.covered.TestCoveredColumnIndexCodec.testGeneratedIndexUpdates(TestCoveredColumnIndexCodec.java:220)
> {code}
>  
> MutableIndexIT fails as well (for non-transactional indexes)
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)