[GitHub] [superset] geido commented on a change in pull request #12598: fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals

[GitBox <gi...@apache.org>]

geido commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560384859



##########
File path: superset-frontend/src/common/components/Modal/Modal.tsx
##########
@@ -42,12 +42,15 @@ interface ModalProps {
   footer?: React.ReactNode;
   wrapProps?: object;
   height?: string;
+  scrollTableMode?: boolean;
 }
 
 interface StyledModalProps extends SupersetThemeProps {
   maxWidth?: string;
   responsive?: boolean;
   height?: string;
+  scrollTableMode?: boolean;

Review comment:
       You would see the white padding at the bottom overlaying the table and creating a disturbing effect for the eyes. I am happy to change the name or pass it down differently if you have a better idea though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org