You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "abeizn (via GitHub)" <gi...@apache.org> on 2023/02/14 10:38:49 UTC
[GitHub] [incubator-devlake] abeizn opened a new pull request, #4412: fix: modity issues story_point from int64 to float64
abeizn opened a new pull request, #4412:
URL: https://github.com/apache/incubator-devlake/pull/4412
### Summary
modity issues story_point from int64 to float64
### Does this close any open issues?
Closes #4325
### Screenshots
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4412: fix: modity issues story_point from int64 to float64
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 commented on code in PR #4412:
URL: https://github.com/apache/incubator-devlake/pull/4412#discussion_r1106605589
##########
backend/plugins/jira/models/migrationscripts/20230214_remove_issue_stdstorypoint.go:
##########
@@ -0,0 +1,46 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package migrationscripts
+
+import (
+ "github.com/apache/incubator-devlake/core/context"
+ "github.com/apache/incubator-devlake/core/errors"
+ "github.com/apache/incubator-devlake/core/plugin"
+)
+
+var _ plugin.MigrationScript = (*removeIssueStdStoryPoint)(nil)
+
+type removeIssueStdStoryPoint struct{}
+
+func (*removeIssueStdStoryPoint) Up(basicRes context.BasicRes) errors.Error {
+ db := basicRes.GetDal()
+ err := db.DropColumns("_tool_jira_issues", "std_story_point")
Review Comment:
why do we remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mindlesscloud merged pull request #4412: fix: modity issues story_point from int64 to float64
Posted by "mindlesscloud (via GitHub)" <gi...@apache.org>.
mindlesscloud merged PR #4412:
URL: https://github.com/apache/incubator-devlake/pull/4412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on pull request #4412: fix: modity issues story_point from int64 to float64
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 commented on PR #4412:
URL: https://github.com/apache/incubator-devlake/pull/4412#issuecomment-1430697983
Can you also provide a screenshot after building?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org