You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/03/22 04:43:38 UTC
[kudu-CR] trace: fully qualify namespace in macros
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12834
Change subject: trace: fully qualify namespace in macros
......................................................................
trace: fully qualify namespace in macros
Impala imports kudu/util/ but most of the Impala code is not in the
'kudu' namespace. In order for Impala to use the TRACE() macros, it's
thus necessary for them to fully qualify 'kudu::Trace' rather than
assume the macro is being used in a context where 'kudu::' is in scope.
Change-Id: I6365e08e85caa485611a8fdf2c329509911d49ab
---
M src/kudu/util/trace.h
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/12834/1
--
To view, visit http://gerrit.cloudera.org:8080/12834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6365e08e85caa485611a8fdf2c329509911d49ab
Gerrit-Change-Number: 12834
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] trace: fully qualify namespace in macros
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12834 )
Change subject: trace: fully qualify namespace in macros
......................................................................
trace: fully qualify namespace in macros
Impala imports kudu/util/ but most of the Impala code is not in the
'kudu' namespace. In order for Impala to use the TRACE() macros, it's
thus necessary for them to fully qualify 'kudu::Trace' rather than
assume the macro is being used in a context where 'kudu::' is in scope.
Change-Id: I6365e08e85caa485611a8fdf2c329509911d49ab
Reviewed-on: http://gerrit.cloudera.org:8080/12834
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/util/trace.h
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6365e08e85caa485611a8fdf2c329509911d49ab
Gerrit-Change-Number: 12834
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] trace: fully qualify namespace in macros
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12834 )
Change subject: trace: fully qualify namespace in macros
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6365e08e85caa485611a8fdf2c329509911d49ab
Gerrit-Change-Number: 12834
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 28 Mar 2019 19:11:48 +0000
Gerrit-HasComments: No