You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/08/12 04:12:29 UTC
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18843
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
IMPALA-11472: Reduce test dimensions for TestClientSsl
With the addition of extra dimensions for varients
of impala-shell, TestClientSsl currently runs
four different shells against three different protocols
for a total of 12 dimensions. Some tests in TestClientSsl
take a while to run (e.g. test_wildcard_ssl takes 4 minutes
on some platforms). This can take over an hour to run.
This reduces the test dimensions to only tests two
shells (dev python2 and dev python3) with two protocols
(HS2 and HS2-HTTP) for a total of 4 dimensions. This
should reduce the runtime significantly.
Testing:
- Ran TestClientSsl locally and checked the test
dimensions
- Ran shell tests and checked that their test
dimensions don't change
Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
---
M tests/custom_cluster/test_client_ssl.py
M tests/shell/util.py
2 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/18843/1
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18843 )
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8441/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Aug 2022 04:13:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18843 )
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
Patch Set 1:
This matters the most for Centos 7. The performance issue doesn't seem to hit Ubuntu.
The test failure is unrelated, rebasing and retrying.
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 16:45:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18843 )
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
Patch Set 2: Code-Review+1
Carry +1
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 16:46:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18843 )
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11151/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Aug 2022 04:28:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18843 )
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 21:34:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18843 )
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8441/
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Aug 2022 09:00:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18843 )
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
Patch Set 1: Code-Review+1
Jenkins error is in an unrelated test case.
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 15:54:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18843 )
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
IMPALA-11472: Reduce test dimensions for TestClientSsl
With the addition of extra dimensions for varients
of impala-shell, TestClientSsl currently runs
four different shells against three different protocols
for a total of 12 dimensions. Some tests in TestClientSsl
take a while to run (e.g. test_wildcard_ssl takes 4 minutes
on some platforms). This can take over an hour to run.
This reduces the test dimensions to only tests two
shells (dev python2 and dev python3) with two protocols
(HS2 and HS2-HTTP) for a total of 4 dimensions. This
should reduce the runtime significantly.
Testing:
- Ran TestClientSsl locally and checked the test
dimensions
- Ran shell tests and checked that their test
dimensions don't change
Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Reviewed-on: http://gerrit.cloudera.org:8080/18843
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M tests/custom_cluster/test_client_ssl.py
M tests/shell/util.py
2 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18843 )
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 00:13:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11472: Reduce test dimensions for TestClientSsl
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18843 )
Change subject: IMPALA-11472: Reduce test dimensions for TestClientSsl
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8447/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18843
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d4a4792a37cba2231d9999e8bfa2279ba029a05
Gerrit-Change-Number: 18843
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 16:46:44 +0000
Gerrit-HasComments: No