You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/08/22 04:48:25 UTC
Review Request 13723: Added slave recovery network partition test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13723/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/slave_recovery_tests.cpp 28a2628
Diff: https://reviews.apache.org/r/13723/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 13723: Added slave recovery network partition test.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13723/#review25392
-----------------------------------------------------------
Ship it!
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13723/#comment49809>
s/using/ and get/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13723/#comment49810>
s/ack/_statusUpdateAcknowledgement/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13723/#comment49811>
s/ack/_statusUpdateAcknowledgement/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13723/#comment49812>
s/lostStatus/status/ ?
- Vinod Kone
On Aug. 22, 2013, 2:48 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13723/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 2:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 28a2628
>
> Diff: https://reviews.apache.org/r/13723/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 13723: Added slave recovery network partition test.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13723/#review25394
-----------------------------------------------------------
committed. pls mark as submitted.
- Vinod Kone
On Aug. 22, 2013, 3:51 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13723/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 3:51 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 28a2628
>
> Diff: https://reviews.apache.org/r/13723/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 13723: Added slave recovery network partition test.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13723/#review25694
-----------------------------------------------------------
This patch breaks the build (`make check`).
The tests fail.
https://gist.github.com/brndnmtthws/a6e5add8e7a09ffdb9cf
Here's a build fix:
https://reviews.apache.org/r/13892/
- Brenden Matthews
On Aug. 22, 2013, 3:51 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13723/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 3:51 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 28a2628
>
> Diff: https://reviews.apache.org/r/13723/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 13723: Added slave recovery network partition test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13723/
-----------------------------------------------------------
(Updated Aug. 22, 2013, 3:51 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Vinod's comments.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 28a2628
Diff: https://reviews.apache.org/r/13723/diff/
Testing
-------
make check
Thanks,
Jie Yu