You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/07 19:01:22 UTC

[GitHub] [pulsar] merlimat opened a new pull request #11956: [Python] Fixed CMake check to find Python headers and libs

merlimat opened a new pull request #11956:
URL: https://github.com/apache/pulsar/pull/11956


   ### Motivation
   
   The recommended way to find Python headers and libs for CMake is:
   ```
   find_package(Python REQUIRED Development)
   ```
   
   This will ensure we're finding the correct version on all platforms.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] BewareMyPower commented on pull request #11956: [Python] Fixed CMake check to find Python headers and libs

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #11956:
URL: https://github.com/apache/pulsar/pull/11956#issuecomment-914771845


   `FindPython` was firstly introduced from 3.12, see https://cmake.org/cmake/help/latest/module/FindPython.html#module:FindPython. But the minimum version of CMake is only 3.4 now. We need to update related Dockerfiles like `build/docker/Dockerfile` and files under `pulsar-client-cpp/docker`. We should also upload a new docker image for test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat closed pull request #11956: [Python] Fixed CMake check to find Python headers and libs

Posted by GitBox <gi...@apache.org>.
merlimat closed pull request #11956:
URL: https://github.com/apache/pulsar/pull/11956


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org