You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "thswlsqls (via GitHub)" <gi...@apache.org> on 2026/07/03 23:03:47 UTC
[PR] Docs: Fix reversed Flink binary/varbinary to Iceberg type mapping [iceberg]
thswlsqls opened a new pull request, #17090:
URL: https://github.com/apache/iceberg/pull/17090
Closes #17088
## Summary
- The "Flink to Iceberg" type mapping table listed `binary -> binary` and `varbinary -> fixed`, the exact opposite of what `FlinkTypeToType.visit(BinaryType)`/`visit(VarBinaryType)` actually produce (`binary -> fixed`, `varbinary -> binary`).
- The reverse "Iceberg to Flink" table on the same page already documents this pairing correctly, so the two tables were self-contradictory.
- Swapped the two table cells to match `flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/FlinkTypeToType.java` line 85-91.
## Testing done
- Docs-only change, no behavior change — no test added. Verified by re-reading `FlinkTypeToType.java`/`TypeToFlinkType.java` and confirming the fix matches both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Fix reversed Flink binary/varbinary to Iceberg type mapping [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #17090:
URL: https://github.com/apache/iceberg/pull/17090#issuecomment-4896222988
Merged to main.
Thanks @thswlsqls for the fix and @ebyhr, @wombatu-kun and @Guosmilesmile for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Fix reversed Flink binary/varbinary to Iceberg type mapping [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #17090:
URL: https://github.com/apache/iceberg/pull/17090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org