[GitHub] [flink] fapaul commented on a change in pull request #18345: [FLINK-25440][doc][pulsar] Both stopCursor and startCursor now uses publish time instead of event time

[GitBox <gi...@apache.org>]

fapaul commented on a change in pull request #18345:
URL: https://github.com/apache/flink/pull/18345#discussion_r808044188



##########
File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/StopCursor.java
##########
@@ -71,7 +71,7 @@ static StopCursor afterMessageId(MessageId messageId) {
         return new MessageIdStopCursor(messageId, false);
     }
 
-    static StopCursor atEventTime(long timestamp) {
+    static StopCursor atPublishTime(long timestamp) {

Review comment:
       I am afraid this change it not easily doable. The class is annotated with `@PublicEvolving` and this may break existing users setup.
   
   The only way I see is that you can deprecate `atEventTime` and create another method `atPublishTime`. In the next release we can then safely remove `atEventTime`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org