You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/13 16:38:59 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #4085: Store StructArray entries in MapArray

tustvold opened a new pull request, #4085:
URL: https://github.com/apache/arrow-rs/pull/4085

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   This was something that came up on https://github.com/apache/arrow-rs/pull/4061#discussion_r1164442141
   
   Not only was the previous formulation redundant, but also was unnecessarily confusing
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4085: Store StructArray entries in MapArray

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4085:
URL: https://github.com/apache/arrow-rs/pull/4085#discussion_r1165787189


##########
arrow-array/src/array/map_array.rs:
##########
@@ -54,35 +50,34 @@ impl MapArray {
 
     /// Returns a reference to the keys of this map
     pub fn keys(&self) -> &ArrayRef {
-        &self.keys
+        self.entries.column(0)
     }
 
     /// Returns a reference to the values of this map
     pub fn values(&self) -> &ArrayRef {
-        &self.values
+        self.entries.column(1)
     }
 
     /// Returns a reference to the [`StructArray`] entries of this map
-    pub fn entries(&self) -> &ArrayRef {
+    pub fn entries(&self) -> &StructArray {

Review Comment:
   This is a breaking change, but I think is significantly easier to understand, especially since it was already documented to be a `StructArray` :sweat_smile: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4085: Store StructArray entries in MapArray

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4085:
URL: https://github.com/apache/arrow-rs/pull/4085#discussion_r1165786593


##########
parquet/src/arrow/arrow_writer/levels.rs:
##########
@@ -175,7 +175,7 @@ impl LevelInfoBuilder {
     }
 
     /// Given an `array`, write the level data for the elements in `range`
-    fn write(&mut self, array: &ArrayRef, range: Range<usize>) {
+    fn write(&mut self, array: &dyn Array, range: Range<usize>) {

Review Comment:
   This change is necessary because `MapArray::entries` now returns `StructArray` instead of `&ArrayRef`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #4085: Store StructArray entries in MapArray

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4085:
URL: https://github.com/apache/arrow-rs/pull/4085


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org