You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by milamberspace <gi...@git.apache.org> on 2015/08/14 23:03:08 UTC
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/699
Update L10N resource files on master branch with 4.6 translation stri…
…ngs from Transifex (20150814)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milamberspace/cloudstack L10N-update-updateMaster-20150814
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/699.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #699
----
commit 05ef17adc1b25cfc9c53f9705024272cf8b98718
Author: Milamber <mi...@apache.org>
Date: 2015-08-14T21:00:30Z
Update L10N resource files on master branch with 4.6 translation strings from Transifex (20150814)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/699#discussion_r37389129
--- Diff: client/WEB-INF/classes/resources/messages_es.properties ---
@@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, saltar esta gu\u00eda
label.snapshot=Instant\u00c3\u00a1nea
label.snapshot.limits=instant\u00c3\u00a1neas L\u00c3\u00admites
label.snapshot.name=Nombre de instant\u00c3\u00a1neas
-label.snapshot.schedule=Lista de instant\u00c3\u00a1neas
+label.snapshot.s=instant\u00c3\u00a1neas
--- End diff --
Another commit from Mike (Setup != Set up)
https://git1-us-west.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=client/WEB-INF/classes/resources/messages.properties;h=f81a196cf711d709af6a399a6f5e6d275dd7e951;hp=dcbf6c83a24a4cfd6977659d4f531c64c1786edb;hb=e640e0cf;hpb=c0230273cdbdf2558f4a0802d177bd5757de34fd
=> New value for a key on the source language file means remove the old translation (key/value) until a translator (re)translate the new value
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/699#issuecomment-132253698
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/699#discussion_r37314162
--- Diff: client/WEB-INF/classes/resources/messages_es.properties ---
@@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, saltar esta gu\u00eda
label.snapshot=Instant\u00c3\u00a1nea
label.snapshot.limits=instant\u00c3\u00a1neas L\u00c3\u00admites
label.snapshot.name=Nombre de instant\u00c3\u00a1neas
-label.snapshot.schedule=Lista de instant\u00c3\u00a1neas
+label.snapshot.s=instant\u00c3\u00a1neas
--- End diff --
is that change correct ? seems weird
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/699#discussion_r37315501
--- Diff: client/WEB-INF/classes/resources/messages_es.properties ---
@@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, saltar esta gu\u00eda
label.snapshot=Instant\u00c3\u00a1nea
label.snapshot.limits=instant\u00c3\u00a1neas L\u00c3\u00admites
label.snapshot.name=Nombre de instant\u00c3\u00a1neas
-label.snapshot.schedule=Lista de instant\u00c3\u00a1neas
+label.snapshot.s=instant\u00c3\u00a1neas
--- End diff --
Yes, the value of label.snapshot.s key has been changes by mike (so need a new translation on each language):
https://git1-us-west.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=client/WEB-INF/classes/resources/messages.properties;h=dcbf6c83a24a4cfd6977659d4f531c64c1786edb;hp=701582cb1321281bdede5daa0b5dc80e69375a35;hb=c0230273;hpb=406c2c00b267483ef6fe6c84b9a187458662cb9f
The git diff shown the label.snapshot.s key before label.snapshot.schedule because the messages_es.properties is in alphabetic order.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/699#issuecomment-132485606
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/699#discussion_r37389322
--- Diff: client/WEB-INF/classes/resources/messages_es.properties ---
@@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, saltar esta gu\u00eda
label.snapshot=Instant\u00c3\u00a1nea
label.snapshot.limits=instant\u00c3\u00a1neas L\u00c3\u00admites
label.snapshot.name=Nombre de instant\u00c3\u00a1neas
-label.snapshot.schedule=Lista de instant\u00c3\u00a1neas
+label.snapshot.s=instant\u00c3\u00a1neas
--- End diff --
Got it :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/699#discussion_r37388778
--- Diff: client/WEB-INF/classes/resources/messages_es.properties ---
@@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente, saltar esta gu\u00eda
label.snapshot=Instant\u00c3\u00a1nea
label.snapshot.limits=instant\u00c3\u00a1neas L\u00c3\u00admites
label.snapshot.name=Nombre de instant\u00c3\u00a1neas
-label.snapshot.schedule=Lista de instant\u00c3\u00a1neas
+label.snapshot.s=instant\u00c3\u00a1neas
--- End diff --
you are removing label.snapshot.schedule as well, that was not changed in the commit from Mike, is that intended?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update L10N resource files on master bran...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/699
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---