You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/04/29 22:29:26 UTC
[Impala-ASF-CR] IMPALA-8466: disable test caching ddl in dockerized cluster
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13181
Change subject: IMPALA-8466: disable test_caching_ddl in dockerized cluster
......................................................................
IMPALA-8466: disable test_caching_ddl in dockerized cluster
The test creates partitions with file:// URLs pointing at the
host filesystem, which isn't accessible from within the
containers. The only reason the test passed earlier was because
of a bug fixed by the IMPALA-8454 patches which suppressed
the error.
Change-Id: If4e67cf7f5d993c15cb5e1114beb099d0dfdc325
---
M tests/query_test/test_hdfs_caching.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/13181/1
--
To view, visit http://gerrit.cloudera.org:8080/13181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4e67cf7f5d993c15cb5e1114beb099d0dfdc325
Gerrit-Change-Number: 13181
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8466: disable test caching ddl in dockerized cluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13181 )
Change subject: IMPALA-8466: disable test_caching_ddl in dockerized cluster
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4e67cf7f5d993c15cb5e1114beb099d0dfdc325
Gerrit-Change-Number: 13181
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 06:45:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8466: disable test caching ddl in dockerized cluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13181 )
Change subject: IMPALA-8466: disable test_caching_ddl in dockerized cluster
......................................................................
IMPALA-8466: disable test_caching_ddl in dockerized cluster
The test creates partitions with file:// URLs pointing at the
host filesystem, which isn't accessible from within the
containers. The only reason the test passed earlier was because
of a bug fixed by the IMPALA-8454 patches which suppressed
the error.
Change-Id: If4e67cf7f5d993c15cb5e1114beb099d0dfdc325
Reviewed-on: http://gerrit.cloudera.org:8080/13181
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_hdfs_caching.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If4e67cf7f5d993c15cb5e1114beb099d0dfdc325
Gerrit-Change-Number: 13181
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-8466: disable test caching ddl in dockerized cluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13181 )
Change subject: IMPALA-8466: disable test_caching_ddl in dockerized cluster
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4e67cf7f5d993c15cb5e1114beb099d0dfdc325
Gerrit-Change-Number: 13181
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 11:48:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8466: disable test caching ddl in dockerized cluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13181 )
Change subject: IMPALA-8466: disable test_caching_ddl in dockerized cluster
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2980/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4e67cf7f5d993c15cb5e1114beb099d0dfdc325
Gerrit-Change-Number: 13181
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 23:26:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8466: disable test caching ddl in dockerized cluster
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13181 )
Change subject: IMPALA-8466: disable test_caching_ddl in dockerized cluster
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this
--
To view, visit http://gerrit.cloudera.org:8080/13181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4e67cf7f5d993c15cb5e1114beb099d0dfdc325
Gerrit-Change-Number: 13181
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 06:12:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8466: disable test caching ddl in dockerized cluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13181 )
Change subject: IMPALA-8466: disable test_caching_ddl in dockerized cluster
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4114/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4e67cf7f5d993c15cb5e1114beb099d0dfdc325
Gerrit-Change-Number: 13181
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Apr 2019 06:45:41 +0000
Gerrit-HasComments: No