You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/11 09:37:37 UTC

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1345: [IOTDB-759] Refactor MNode by removing InternalMNode

HTHou commented on a change in pull request #1345:
URL: https://github.com/apache/incubator-iotdb/pull/1345#discussion_r438663235



##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/utils/ReadWriteIOUtils.java
##########
@@ -105,15 +105,15 @@ public static byte readByte(ByteBuffer buffer) {
   /**
    * write if the object not equals null. Eg, object eauals null, then write false.
    */
-  public static int writeIsNotNull(Object object, OutputStream outputStream) throws IOException {
-    return write(object != null, outputStream);
+  public static int writeIsNull(Object object, OutputStream outputStream) throws IOException {
+    return write(object == null, outputStream);
   }
 
   /**
    * write if the object not equals null. Eg, object eauals null, then write false.
    */

Review comment:
       ```suggestion
     /**
      * write if the object equals null. Eg, object equals null, then write true.
      */
   ```

##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/utils/ReadWriteIOUtils.java
##########
@@ -105,15 +105,15 @@ public static byte readByte(ByteBuffer buffer) {
   /**
    * write if the object not equals null. Eg, object eauals null, then write false.
    */

Review comment:
       ```suggestion
     /**
      * write if the object equals null. Eg, object equals null, then write true.
      */
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org