You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/02 12:17:58 UTC
[jira] [Commented] (BEAM-880) Avoid emitting default empty iterable
in PAssert.GroupedGlobally.
[ https://issues.apache.org/jira/browse/BEAM-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628779#comment-15628779 ]
ASF GitHub Bot commented on BEAM-880:
-------------------------------------
GitHub user amitsela opened a pull request:
https://github.com/apache/incubator-beam/pull/1257
[BEAM-880] Avoid emitting default empty iterable in PAssert.GroupedGl…
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
…obally.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amitsela/incubator-beam passert-remove-empty-dummy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1257
----
commit 99a79e3d19a6584a19c628e71a21400f97b4754a
Author: Sela <an...@paypal.com>
Date: 2016-11-02T12:17:12Z
[BEAM-880] Avoid emitting default empty iterable in PAssert.GroupedGlobally.
----
> Avoid emitting default empty iterable in PAssert.GroupedGlobally.
> -----------------------------------------------------------------
>
> Key: BEAM-880
> URL: https://issues.apache.org/jira/browse/BEAM-880
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Amit Sela
> Assignee: Amit Sela
>
> Filter to remove the default dummy so that an empty PCollection is actually empty and doesn't contain a single-element empty iterable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)