You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/08 08:54:47 UTC

[GitHub] [incubator-eventmesh] LIU-WEI-git opened a new pull request, #1237: [ISSUE #270] Upgrade pravega connector

LIU-WEI-git opened a new pull request, #1237:
URL: https://github.com/apache/incubator-eventmesh/pull/1237

   Fixes issue #270 with related PR #1203.
   
   ### Motivation
   
   Upgrade pravega connector
   
   ### Modifications
   
   - Add doc to introduce pravega connector
   - SubscribeTask supports EventMeshAsyncConsumeContext.commit
   - Upgrade creation of ReaderGroup and Reader and fix bug
   - Add license files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] LIU-WEI-git commented on pull request #1237: [ISSUE #270] Upgrade pravega connector

Posted by GitBox <gi...@apache.org>.
LIU-WEI-git commented on PR #1237:
URL: https://github.com/apache/incubator-eventmesh/pull/1237#issuecomment-1240825251

   > @LIU-WEI-git please split into several smaller pr.
   
   Hi, I have split this PR and started PR #1240 and PR #1242. Please review them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #1237: [ISSUE #270] Upgrade pravega connector

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on PR #1237:
URL: https://github.com/apache/incubator-eventmesh/pull/1237#issuecomment-1240780884

   @LIU-WEI-git please split into several smaller pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1237: [ISSUE #270] Upgrade pravega connector

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1237:
URL: https://github.com/apache/incubator-eventmesh/pull/1237#issuecomment-1240534097

   # [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1237](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33407e0) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/5101b39df2695b02924041603088601e4cb5903e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5101b39) will **increase** coverage by `0.03%`.
   > The diff coverage is `11.36%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1237      +/-   ##
   ============================================
   + Coverage     11.19%   11.23%   +0.03%     
   - Complexity      758      763       +5     
   ============================================
     Files           421      421              
     Lines         24580    24592      +12     
     Branches       2683     2686       +3     
   ============================================
   + Hits           2752     2762      +10     
   - Misses        21565    21567       +2     
     Partials        263      263              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/java/org/apache/eventmesh/common/Constants.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9Db25zdGFudHMuamF2YQ==) | `85.71% <ø> (ø)` | |
   | [...entmesh/connector/pravega/PravegaConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1wcmF2ZWdhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3ByYXZlZ2EvUHJhdmVnYUNvbnN1bWVySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...che/eventmesh/connector/pravega/SubscribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1wcmF2ZWdhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3ByYXZlZ2EvU3Vic2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ntmesh/connector/pravega/client/PravegaClient.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1wcmF2ZWdhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3ByYXZlZ2EvY2xpZW50L1ByYXZlZ2FDbGllbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...entmesh/connector/pravega/client/PravegaEvent.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1wcmF2ZWdhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3ByYXZlZ2EvY2xpZW50L1ByYXZlZ2FFdmVudC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...otocol/meshmessage/MeshMessageProtocolAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9NZXNoTWVzc2FnZVByb3RvY29sQWRhcHRvci5qYXZh) | `4.34% <0.00%> (ø)` | |
   | [...age/resolver/grpc/GrpcMessageProtocolResolver.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtbWVzaG1lc3NhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9wcm90b2NvbC9tZXNobWVzc2FnZS9yZXNvbHZlci9ncnBjL0dycGNNZXNzYWdlUHJvdG9jb2xSZXNvbHZlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...me/core/protocol/grpc/push/WebhookPushRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wdXNoL1dlYmhvb2tQdXNoUmVxdWVzdC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...ventmesh/client/grpc/util/EventMeshClientUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvdXRpbC9FdmVudE1lc2hDbGllbnRVdGlsLmphdmE=) | `88.97% <33.33%> (ø)` | |
   | [...core/protocol/http/processor/WebHookProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvV2ViSG9va1Byb2Nlc3Nvci5qYXZh) | `75.00% <66.66%> (+75.00%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1237/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #1237: [ISSUE #1243] Upgrade pravega connector

Posted by GitBox <gi...@apache.org>.
qqeasonchen merged PR #1237:
URL: https://github.com/apache/incubator-eventmesh/pull/1237


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org