You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Bruno P. Kinoshita" <br...@yahoo.com.br> on 2012/07/19 22:59:41 UTC
[functor] Generify ComparableComparator based on Commons-Collection ComparableComparator
Hi all,
In [functor], the class org.apache.commons.functor.core.comparator.ComparableComparator [1] is used by some functors and, as the name says, is a comparator of comparables. I was reviewing the raw types in [functor] tests when I stumbled across this class, and noticed it hasn't been "generified" yet, and that its javadoc says "See Commons-Collections for a public version of this class.".
The commons-collection ComparableComparator is already generified, so I thought about trying to generify [functor]'s ComparableComparator using this version as reference (and maybe update its javadoc as well).
Does it sound like a good idea? Any thoughts on this?
Thank you in advance!
[1] http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java?view=markup
[2] http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparableComparator.java?view=markup
Bruno P. Kinoshita
http://kinoshita.eti.br
http://tupilabs.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [functor] Generify ComparableComparator based on
Commons-Collection ComparableComparator
Posted by Simone Tripodi <si...@apache.org>.
Thanks to you! :)
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Fri, Jul 20, 2012 at 7:05 PM, Bruno P. Kinoshita
<br...@yahoo.com.br> wrote:
>
> Olá Simo! :-)
>
> Issue created [1], will work on this during this weekend.
>
>
> Many thanks!
>
>
> [1] https://issues.apache.org/jira/browse/FUNCTOR-22
>
> Bruno P. Kinoshita
> http://kinoshita.eti.br
> http://tupilabs.com
>
>
>>________________________________
>> From: Simone Tripodi <si...@apache.org>
>>To: Commons Developers List <de...@commons.apache.org>; Bruno P. Kinoshita <br...@yahoo.com.br>
>>Sent: Friday, 20 July 2012 4:31 AM
>>Subject: Re: [functor] Generify ComparableComparator based on Commons-Collection ComparableComparator
>>
>>Olá Bruno!
>>
>>go for it! The reason of the "See Commons-Collections for a public
>>version of this class." comment is more historical than technical -
>>anyway, +1 to generify ComparableComparator.
>>
>>TIA!
>>-Simo
>>
>>http://people.apache.org/~simonetripodi/
>>http://simonetripodi.livejournal.com/
>>http://twitter.com/simonetripodi
>>http://www.99soft.org/
>>
>>
>>On Thu, Jul 19, 2012 at 10:59 PM, Bruno P. Kinoshita
>><br...@yahoo.com.br> wrote:
>>> Hi all,
>>>
>>> In [functor], the class org.apache.commons.functor.core.comparator.ComparableComparator [1] is used by some functors and, as the name says, is a comparator of comparables. I was reviewing the raw types in [functor] tests when I stumbled across this class, and noticed it hasn't been "generified" yet, and that its javadoc says "See Commons-Collections for a public version of this class.".
>>>
>>>
>>> The commons-collection ComparableComparator is already generified, so I thought about trying to generify [functor]'s ComparableComparator using this version as reference (and maybe update its javadoc as well).
>>>
>>>
>>> Does it sound like a good idea? Any thoughts on this?
>>>
>>> Thank you in advance!
>>>
>>>
>>> [1] http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java?view=markup
>>> [2] http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparableComparator.java?view=markup
>>>
>>> Bruno P. Kinoshita
>>> http://kinoshita.eti.br
>>> http://tupilabs.com
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [functor] Generify ComparableComparator based on Commons-Collection ComparableComparator
Posted by "Bruno P. Kinoshita" <br...@yahoo.com.br>.
Olá Simo! :-)
Issue created [1], will work on this during this weekend.
Many thanks!
[1] https://issues.apache.org/jira/browse/FUNCTOR-22
Bruno P. Kinoshita
http://kinoshita.eti.br
http://tupilabs.com
>________________________________
> From: Simone Tripodi <si...@apache.org>
>To: Commons Developers List <de...@commons.apache.org>; Bruno P. Kinoshita <br...@yahoo.com.br>
>Sent: Friday, 20 July 2012 4:31 AM
>Subject: Re: [functor] Generify ComparableComparator based on Commons-Collection ComparableComparator
>
>Olá Bruno!
>
>go for it! The reason of the "See Commons-Collections for a public
>version of this class." comment is more historical than technical -
>anyway, +1 to generify ComparableComparator.
>
>TIA!
>-Simo
>
>http://people.apache.org/~simonetripodi/
>http://simonetripodi.livejournal.com/
>http://twitter.com/simonetripodi
>http://www.99soft.org/
>
>
>On Thu, Jul 19, 2012 at 10:59 PM, Bruno P. Kinoshita
><br...@yahoo.com.br> wrote:
>> Hi all,
>>
>> In [functor], the class org.apache.commons.functor.core.comparator.ComparableComparator [1] is used by some functors and, as the name says, is a comparator of comparables. I was reviewing the raw types in [functor] tests when I stumbled across this class, and noticed it hasn't been "generified" yet, and that its javadoc says "See Commons-Collections for a public version of this class.".
>>
>>
>> The commons-collection ComparableComparator is already generified, so I thought about trying to generify [functor]'s ComparableComparator using this version as reference (and maybe update its javadoc as well).
>>
>>
>> Does it sound like a good idea? Any thoughts on this?
>>
>> Thank you in advance!
>>
>>
>> [1] http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java?view=markup
>> [2] http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparableComparator.java?view=markup
>>
>> Bruno P. Kinoshita
>> http://kinoshita.eti.br
>> http://tupilabs.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [functor] Generify ComparableComparator based on
Commons-Collection ComparableComparator
Posted by Simone Tripodi <si...@apache.org>.
Olá Bruno!
go for it! The reason of the "See Commons-Collections for a public
version of this class." comment is more historical than technical -
anyway, +1 to generify ComparableComparator.
TIA!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Thu, Jul 19, 2012 at 10:59 PM, Bruno P. Kinoshita
<br...@yahoo.com.br> wrote:
> Hi all,
>
> In [functor], the class org.apache.commons.functor.core.comparator.ComparableComparator [1] is used by some functors and, as the name says, is a comparator of comparables. I was reviewing the raw types in [functor] tests when I stumbled across this class, and noticed it hasn't been "generified" yet, and that its javadoc says "See Commons-Collections for a public version of this class.".
>
>
> The commons-collection ComparableComparator is already generified, so I thought about trying to generify [functor]'s ComparableComparator using this version as reference (and maybe update its javadoc as well).
>
>
> Does it sound like a good idea? Any thoughts on this?
>
> Thank you in advance!
>
>
> [1] http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java?view=markup
> [2] http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparableComparator.java?view=markup
>
> Bruno P. Kinoshita
> http://kinoshita.eti.br
> http://tupilabs.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org