[GitHub] [spark] LuciferYang commented on pull request #38542: Revert "[SPARK-38550][SQL][CORE] Use a disk-based store to save more debug information for live UI"

[GitBox <gi...@apache.org>]

LuciferYang commented on PR #38542:
URL: https://github.com/apache/spark/pull/38542#issuecomment-1306635799

   > @mridulm There is no full prototype. I will send out a PR soon. I did some benchmarks, it showed using Protobuf as serialization can speed up the read/write 3~4 times compared to the current implementation. Thus, we can use RocksDB as the storage layer, similar to the current `InMemoryStore`. I have to revert this one for removing the duplicated `diskStore` in [4274fb8#diff-0cd94c36f45f50f513aeda6504fda0545270b05e105191131b601eb12b8a656bR42](https://github.com/apache/spark/commit/4274fb8806c25519cac829d00b01132fe08c0cac#diff-0cd94c36f45f50f513aeda6504fda0545270b05e105191131b601eb12b8a656bR42)
   
   @gengliangwang Have you compared `Protobuf` and `Flatbuffers`? From the official benchmark data, `Flatbuffers` may have better performance.
   
   http://google.github.io/flatbuffers/flatbuffers_benchmarks.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org