[GitHub] [kyuubi] bowenliang123 commented on pull request #4963: [KYUUBI #4937] Cleanup spark catalog shim and renamed to catalog utils

["bowenliang123 (via GitHub)" <gi...@apache.org>]

bowenliang123 commented on PR #4963:
URL: https://github.com/apache/kyuubi/pull/4963#issuecomment-1592433648

   > A related PR may worth to evaluate #4465
   
   Seems not enough evidence for the necessity of the suggested changes in that PR.
   As for me, checking the catalog name to `spark_catalog` is more strict than matching in TableCatalog class, and it's appropriate to be placed in the first matching case here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org