You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Lyor Goldstein (Jira)" <ji...@apache.org> on 2022/05/13 15:45:00 UTC
[jira] [Resolved] (SSHD-1261) Sometimes async write listener is not called
[ https://issues.apache.org/jira/browse/SSHD-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lyor Goldstein resolved SSHD-1261.
----------------------------------
Fix Version/s: 2.9.0
Resolution: Fixed
Fixed by [~twolf] through commit [ed873492c|https://github.com/apache/mina-sshd/commit/1ab50fe2faf84ec7a2d1d5658a5276ded873492c]
> Sometimes async write listener is not called
> --------------------------------------------
>
> Key: SSHD-1261
> URL: https://issues.apache.org/jira/browse/SSHD-1261
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: Evgeny Pasynkov
> Assignee: Lyor Goldstein
> Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Hello,
> I have discovered the case when the async write listener is not called.
> Imagine the case: The `ChannelAsyncOutputStream::doWriteIfPossible` method discover that window size is too small (lines 160-167). It setup new future and exit the doWriteIfPossible method, relying on `onWindowExpanded` will be called shortly. But if the channel is disconnected, the method will never be invoked, thus future won't be completed.
> I suggest adding the following override to ChannelAsyncOutputStream class:
> {code:java}
> @Override
> protected void doCloseImmediately() {
> abortCurrentWrite();
> super.doCloseImmediately();
> }
> protected synchronized void abortCurrentWrite() {
> IoWriteFutureImpl future = pendingWrite.get();
> if (future != null) {
> future.setValue(new ClosedChannelException());
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org