You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/04/11 18:01:29 UTC

[GitHub] [trafficserver] bryancall opened a new pull request, #8787: Move error logging to use diags.log instead of error.log

bryancall opened a new pull request, #8787:
URL: https://github.com/apache/trafficserver/pull/8787

   Consistenly using Error() instaed of sometimes using Log:error()


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] github-actions[bot] closed pull request #8787: Move error logging to use diags.log instead of error.log

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #8787: Move error logging to use diags.log instead of error.log
URL: https://github.com/apache/trafficserver/pull/8787


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] maskit commented on pull request #8787: Move error logging to use diags.log instead of error.log

Posted by GitBox <gi...@apache.org>.
maskit commented on PR #8787:
URL: https://github.com/apache/trafficserver/pull/8787#issuecomment-1111622690

   I think we should mark this as incompatible and land this on 10-Dev branch first. Some people may watch error.log for error logs but not diags.log.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bryancall commented on pull request #8787: Move error logging to use diags.log instead of error.log

Posted by GitBox <gi...@apache.org>.
bryancall commented on PR #8787:
URL: https://github.com/apache/trafficserver/pull/8787#issuecomment-1111363524

   [approve ci autest]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bneradt commented on pull request #8787: Move error logging to use diags.log instead of error.log

Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8787:
URL: https://github.com/apache/trafficserver/pull/8787#issuecomment-1095473438

   [approve ci fedora]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bneradt commented on a diff in pull request #8787: Move error logging to use diags.log instead of error.log

Posted by GitBox <gi...@apache.org>.
bneradt commented on code in PR #8787:
URL: https://github.com/apache/trafficserver/pull/8787#discussion_r847617015


##########
proxy/http/HttpSM.cc:
##########
@@ -4175,28 +4175,28 @@ HttpSM::check_sni_host()
             SMDebug("ssl_sni", "[HttpSM::check_sni_host] No SNI for TLS request with hostname %.*s action=%s", host_len, host_name,
                     action_value);
             if (host_sni_policy == 2) {
-              Log::error("%s", lbw()
-                                 .clip(1)
-                                 .print("No SNI for TLS request: connecting to {} for host='{}', returning a 403",
-                                        t_state.client_info.dst_addr, std::string_view{host_name, static_cast<size_t>(host_len)})
-                                 .extend(1)
-                                 .write('\0')
-                                 .data());
+              Error("%s", lbw()
+                            .clip(1)
+                            .print("No SNI for TLS request: connecting to {} for host='{}', returning a 403",
+                                   t_state.client_info.dst_addr, std::string_view{host_name, static_cast<size_t>(host_len)})
+                            .extend(1)
+                            .write('\0')
+                            .data());

Review Comment:
   Maybe keep these connection-oriented messages in error.log? That's what I expect in error.log anyway: connection issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] github-actions[bot] commented on pull request #8787: Move error logging to use diags.log instead of error.log

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8787:
URL: https://github.com/apache/trafficserver/pull/8787#issuecomment-1198811280

   This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org