[GitHub] [cassandra] frankgh commented on a diff in pull request #1701: CASSANDRA-17677: Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle

[GitBox <gi...@apache.org>]

frankgh commented on code in PR #1701:
URL: https://github.com/apache/cassandra/pull/1701#discussion_r905577755


##########
test/unit/org/apache/cassandra/tools/LoaderOptionsTest.java:
##########
@@ -84,38 +84,158 @@ public void testEncryptionSettings() throws Exception
         assertEquals("test.jks", options.clientEncOptions.keystore);
     }
 
+    @Test
+    public void testThrottleDefaultSettings()
+    {
+        LoaderOptions options = LoaderOptions.builder().build();
+        assertEquals(0, options.throttleMebibytes);
+        assertEquals(0, options.interDcThrottleMebibytes);

Review Comment:
   we have another test for entire sstable default settings `testEntireSSTableDefaultSettings`. Do we want to combine them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org