You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "Emily Jiang (JIRA)" <ji...@apache.org> on 2010/09/14 14:18:32 UTC

[jira] Created: (ARIES-408) Refix for the jira-405

Refix for the jira-405
----------------------

                 Key: ARIES-408
                 URL: https://issues.apache.org/jira/browse/ARIES-408
             Project: Aries
          Issue Type: Bug
          Components: JMX
            Reporter: Emily Jiang


FrameworkUtils does not use common split utility method for manifest header process, which was reported by jira 405. However, the original fix for the jira-405 duplicates the code and make the future maintenance more difficult. The better fix will be to use the ManifestHeaderProcessor.split instead of the string's raw split.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ARIES-408) Refix for the jira-405

Posted by "Emily Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ARIES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emily Jiang reassigned ARIES-408:
---------------------------------

    Assignee: Emily Jiang

> Refix for the jira-405
> ----------------------
>
>                 Key: ARIES-408
>                 URL: https://issues.apache.org/jira/browse/ARIES-408
>             Project: Aries
>          Issue Type: Bug
>          Components: JMX
>            Reporter: Emily Jiang
>            Assignee: Emily Jiang
>
> FrameworkUtils does not use common split utility method for manifest header process, which was reported by jira 405. However, the original fix for the jira-405 duplicates the code and make the future maintenance more difficult. The better fix will be to use the ManifestHeaderProcessor.split instead of the string's raw split.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ARIES-408) Refix for the jira-405

Posted by "Emily Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ARIES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912419#action_12912419 ] 

Emily Jiang commented on ARIES-408:
-----------------------------------

I am going to attach a patch for the jira. The fix is to move the ManifestHeserProcessor.split utility method from application utils to aries utils and then make the jmx bundle has a dependency on aries.utils, since the split method is useful and tested thoroughly, designed to be used to split the manifest headers. My impression is that aries.utils is supposed to be the utility bundle for all other bundles. The advantage of this fix is to reduce the code duplication in multiple places and to use the well-tested code:). Any other thoughts?

> Refix for the jira-405
> ----------------------
>
>                 Key: ARIES-408
>                 URL: https://issues.apache.org/jira/browse/ARIES-408
>             Project: Aries
>          Issue Type: Bug
>          Components: JMX
>            Reporter: Emily Jiang
>            Assignee: Emily Jiang
>
> FrameworkUtils does not use common split utility method for manifest header process, which was reported by jira 405. However, the original fix for the jira-405 duplicates the code and make the future maintenance more difficult. The better fix will be to use the ManifestHeaderProcessor.split instead of the string's raw split.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ARIES-408) Consolidate Manifest header parsing/split logic in aries.utils

Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ARIES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bohn updated ARIES-408:
---------------------------

              Summary: Consolidate Manifest header parsing/split logic in aries.utils   (was: Refix for the jira-405)
    Affects Version/s: 0.3

Changing description - while the motivation for this fix was a desire to leverage common function after seeing some duplicate function introduced in Aries-405 it is really primarily about consolidating and sharing the ManifestHeaderUtil split function which has broader usefulness than just as a fix for Aries-405.

> Consolidate Manifest header parsing/split logic in aries.utils 
> ---------------------------------------------------------------
>
>                 Key: ARIES-408
>                 URL: https://issues.apache.org/jira/browse/ARIES-408
>             Project: Aries
>          Issue Type: Bug
>          Components: JMX
>    Affects Versions: 0.3
>            Reporter: Emily Jiang
>            Assignee: Joe Bohn
>         Attachments: jira-408.txt
>
>
> FrameworkUtils does not use common split utility method for manifest header process, which was reported by jira 405. However, the original fix for the jira-405 duplicates the code and make the future maintenance more difficult. The better fix will be to use the ManifestHeaderProcessor.split instead of the string's raw split.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ARIES-408) Refix for the jira-405

Posted by "Emily Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ARIES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emily Jiang updated ARIES-408:
------------------------------

    Attachment: jira-408.txt

This patch was generated at the trunk level.

> Refix for the jira-405
> ----------------------
>
>                 Key: ARIES-408
>                 URL: https://issues.apache.org/jira/browse/ARIES-408
>             Project: Aries
>          Issue Type: Bug
>          Components: JMX
>            Reporter: Emily Jiang
>            Assignee: Emily Jiang
>         Attachments: jira-408.txt
>
>
> FrameworkUtils does not use common split utility method for manifest header process, which was reported by jira 405. However, the original fix for the jira-405 duplicates the code and make the future maintenance more difficult. The better fix will be to use the ManifestHeaderProcessor.split instead of the string's raw split.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ARIES-408) Consolidate Manifest header parsing/split logic in aries.utils

Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ARIES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bohn resolved ARIES-408.
----------------------------

    Fix Version/s: 0.3
       Resolution: Fixed

> Consolidate Manifest header parsing/split logic in aries.utils 
> ---------------------------------------------------------------
>
>                 Key: ARIES-408
>                 URL: https://issues.apache.org/jira/browse/ARIES-408
>             Project: Aries
>          Issue Type: Bug
>          Components: JMX
>    Affects Versions: 0.3
>            Reporter: Emily Jiang
>            Assignee: Joe Bohn
>             Fix For: 0.3
>
>         Attachments: jira-408.txt
>
>
> FrameworkUtils does not use common split utility method for manifest header process, which was reported by jira 405. However, the original fix for the jira-405 duplicates the code and make the future maintenance more difficult. The better fix will be to use the ManifestHeaderProcessor.split instead of the string's raw split.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (ARIES-408) Consolidate Manifest header parsing/split logic in aries.utils

Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ARIES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on ARIES-408 started by Joe Bohn.

> Consolidate Manifest header parsing/split logic in aries.utils 
> ---------------------------------------------------------------
>
>                 Key: ARIES-408
>                 URL: https://issues.apache.org/jira/browse/ARIES-408
>             Project: Aries
>          Issue Type: Bug
>          Components: JMX
>    Affects Versions: 0.3
>            Reporter: Emily Jiang
>            Assignee: Joe Bohn
>         Attachments: jira-408.txt
>
>
> FrameworkUtils does not use common split utility method for manifest header process, which was reported by jira 405. However, the original fix for the jira-405 duplicates the code and make the future maintenance more difficult. The better fix will be to use the ManifestHeaderProcessor.split instead of the string's raw split.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ARIES-408) Refix for the jira-405

Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ARIES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bohn reassigned ARIES-408:
------------------------------

    Assignee: Joe Bohn  (was: Emily Jiang)

> Refix for the jira-405
> ----------------------
>
>                 Key: ARIES-408
>                 URL: https://issues.apache.org/jira/browse/ARIES-408
>             Project: Aries
>          Issue Type: Bug
>          Components: JMX
>            Reporter: Emily Jiang
>            Assignee: Joe Bohn
>         Attachments: jira-408.txt
>
>
> FrameworkUtils does not use common split utility method for manifest header process, which was reported by jira 405. However, the original fix for the jira-405 duplicates the code and make the future maintenance more difficult. The better fix will be to use the ManifestHeaderProcessor.split instead of the string's raw split.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.