You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/13 03:28:51 UTC
[GitHub] [iotdb] GLBB opened a new pull request #2677: Iotdb 1135
GLBB opened a new pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677
## Description
fix bug IOTDB-1135
using get all path method replace origin get count method, and add some test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on a change in pull request #2677: [IOTDB-1135] count timeseries prefix path bug
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677#discussion_r579755728
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##########
@@ -856,11 +858,46 @@ int getAllTimeseriesCount(PartialPath prefixPath) throws MetadataException {
if (nodes.length == 0 || !nodes[0].equals(root.getName())) {
throw new IllegalPathException(prefixPath.getFullPath());
}
+ Holder<Integer> countHolder = new Holder<>(0);
try {
- return getCount(root, nodes, 1);
+ getCount(root, nodes, 1, countHolder, false);
} catch (PathNotExistException e) {
throw new PathNotExistException(prefixPath.getFullPath());
}
+ return countHolder.getValue();
+ }
+
+ /** Traverse the MTree to get the count of timeseries. */
+ private void getCount(
+ MNode node, String[] nodes, int idx, Holder<Integer> countHolder, boolean wildcard)
Review comment:
Holder can be avoided just define the function as `private int getCount`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #2677: [IOTDB-1135] count timeseries prefix path bug
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677#discussion_r579607672
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##########
@@ -856,11 +858,46 @@ int getAllTimeseriesCount(PartialPath prefixPath) throws MetadataException {
if (nodes.length == 0 || !nodes[0].equals(root.getName())) {
throw new IllegalPathException(prefixPath.getFullPath());
}
+ Holder<Integer> countHolder = new Holder<>(0);
try {
- return getCount(root, nodes, 1);
+ getAllTimeseriesCountHelper(root, nodes, 1, countHolder, false);
Review comment:
I feel the method name `getAllTimeseriesCountHelper` is not clear enough. How about just keep the origin method name `getCount`?
##########
File path: server/src/main/java/org/apache/iotdb/db/utils/Holder.java
##########
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * <p>http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * <p>Unless required by applicable law or agreed to in writing, software distributed under the
+ * License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
Review comment:
```suggestion
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] GLBB commented on a change in pull request #2677: [IOTDB-1135] count timeseries prefix path bug
Posted by GitBox <gi...@apache.org>.
GLBB commented on a change in pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677#discussion_r579633079
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##########
@@ -856,11 +858,46 @@ int getAllTimeseriesCount(PartialPath prefixPath) throws MetadataException {
if (nodes.length == 0 || !nodes[0].equals(root.getName())) {
throw new IllegalPathException(prefixPath.getFullPath());
}
+ Holder<Integer> countHolder = new Holder<>(0);
try {
- return getCount(root, nodes, 1);
+ getAllTimeseriesCountHelper(root, nodes, 1, countHolder, false);
Review comment:
ok,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #2677: [IOTDB-1135] count timeseries prefix path bug
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677#issuecomment-782995241
I have tried on my mac and everything works great now.
```
IoTDB> show timeseries root.ln.wf.wt.tdouble
+------------------------------+-----+-------------+--------+--------+-----------+----+----------+
| timeseries|alias|storage group|dataType|encoding|compression|tags|attributes|
+------------------------------+-----+-------------+--------+--------+-----------+----+----------+
| root.ln.wf.wt.tdouble| null| root.ln| FLOAT| GORILLA| SNAPPY|null| null|
|root.ln.wf.wt.tdouble.tdouble1| null| root.ln| FLOAT| GORILLA| SNAPPY|null| null|
|root.ln.wf.wt.tdouble.tdouble2| null| root.ln| FLOAT| GORILLA| SNAPPY|null| null|
+------------------------------+-----+-------------+--------+--------+-----------+----+----------+
Total line number = 3
It costs 0.124s
IoTDB> count timeseries root.ln.wf.wt.tdouble
+-----+
|count|
+-----+
| 3|
+-----+
Total line number = 1
It costs 0.013s
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] GLBB commented on pull request #2677: Iotdb 1135
Posted by GitBox <gi...@apache.org>.
GLBB commented on pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677#issuecomment-778583275
> Line 549, try to update the sonar plugin version to 3.8.0.2131
thanks your guide, can you help me to solve the last check, I hava no idea about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #2677: Iotdb 1135
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677#issuecomment-778575631
Line 549, try to update the sonar plugin version to 3.8.0.2131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #2677: Iotdb 1135
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677#issuecomment-778716259
Hi, I am reviewing this PR and find some issues.
But I need some time to confirm current MTree's structure. No hurry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] GLBB commented on a change in pull request #2677: [IOTDB-1135] count timeseries prefix path bug
Posted by GitBox <gi...@apache.org>.
GLBB commented on a change in pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677#discussion_r579765902
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##########
@@ -856,11 +858,46 @@ int getAllTimeseriesCount(PartialPath prefixPath) throws MetadataException {
if (nodes.length == 0 || !nodes[0].equals(root.getName())) {
throw new IllegalPathException(prefixPath.getFullPath());
}
+ Holder<Integer> countHolder = new Holder<>(0);
try {
- return getCount(root, nodes, 1);
+ getCount(root, nodes, 1, countHolder, false);
} catch (PathNotExistException e) {
throw new PathNotExistException(prefixPath.getFullPath());
}
+ return countHolder.getValue();
+ }
+
+ /** Traverse the MTree to get the count of timeseries. */
+ private void getCount(
+ MNode node, String[] nodes, int idx, Holder<Integer> countHolder, boolean wildcard)
Review comment:
ok, i remove holder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #2677: [IOTDB-1135] count timeseries prefix path bug
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] GLBB commented on a change in pull request #2677: [IOTDB-1135] count timeseries prefix path bug
Posted by GitBox <gi...@apache.org>.
GLBB commented on a change in pull request #2677:
URL: https://github.com/apache/iotdb/pull/2677#discussion_r579633079
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
##########
@@ -856,11 +858,46 @@ int getAllTimeseriesCount(PartialPath prefixPath) throws MetadataException {
if (nodes.length == 0 || !nodes[0].equals(root.getName())) {
throw new IllegalPathException(prefixPath.getFullPath());
}
+ Holder<Integer> countHolder = new Holder<>(0);
try {
- return getCount(root, nodes, 1);
+ getAllTimeseriesCountHelper(root, nodes, 1, countHolder, false);
Review comment:
ok, today night , i will change the method name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org