You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gora.apache.org by alfonsonishikawa <gi...@git.apache.org> on 2018/03/03 12:00:20 UTC

[GitHub] gora pull request #130: GORA-530: Removed redundant logging on several try/c...

GitHub user alfonsonishikawa opened a pull request:

    https://github.com/apache/gora/pull/130

    GORA-530: Removed redundant logging on several try/catch

    Hi!
    In this patch basically I removed the redundand "logging + throw" when the log message is the same as in the exception.
    Sorry for the mess of two pull requests :(
    Please comment anything you find that don't convice you.
    
    Thanks!
    
    https://issues.apache.org/jira/browse/GORA-530

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alfonsonishikawa/gora GORA-530

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #130
    
----
commit b782a0a58ad5886604e1e80a051727dc7fe101f3
Author: Alfonso Nishikawa Muñumer <al...@...>
Date:   2018-03-03T11:52:04Z

    GORA-530: Removed redundant logging on several try/catch

----


---

[GitHub] gora issue #130: GORA-530: Removed redundant logging on several try/catch

Posted by alfonsonishikawa <gi...@git.apache.org>.

Github user alfonsonishikawa commented on the issue:

    https://github.com/apache/gora/pull/130
  
    Done, thank you!


---

[GitHub] gora issue #130: GORA-530: Removed redundant logging on several try/catch

Posted by lewismc <gi...@git.apache.org>.

Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/130
  
    +1


---

[GitHub] gora issue #130: GORA-530: Removed redundant logging on several try/catch

Posted by renato2099 <gi...@git.apache.org>.

Github user renato2099 commented on the issue:

    https://github.com/apache/gora/pull/130
  
    Hi @alfonsonishikawa , thanks for doing this!
    I think the first option was also ok because one thing is logging what the problem was and other throwing the exception for the application using Gora to deal with it as it fits better to the application.
    what do you think @lewismc ?


---

[GitHub] gora issue #130: GORA-530: Removed redundant logging on several try/catch

Posted by lewismc <gi...@git.apache.org>.

Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/130
  
    @alfonsonishikawa @renato2099 I think this looks good. Tidies up Exception handling quite nicely.


---

[GitHub] gora issue #130: GORA-530: Removed redundant logging on several try/catch

Posted by alfonsonishikawa <gi...@git.apache.org>.

Github user alfonsonishikawa commented on the issue:

    https://github.com/apache/gora/pull/130
  
    I can't believe how sausage-fingers I must be. I left a strange Eclipse autoimport at https://github.com/apache/gora/blob/master/gora-core/src/main/java/org/apache/gora/persistency/impl/BeanFactoryImpl.java#L28 . If you don't mind, I will straight delete it, test and push without a pull request -it is not being used, safe-. How embarrassing. Sorry.


---

[GitHub] gora issue #130: GORA-530: Removed redundant logging on several try/catch

Posted by lewismc <gi...@git.apache.org>.

Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/130
  
    @alfonsonishikawa can you commit to master?


---

[GitHub] gora pull request #130: GORA-530: Removed redundant logging on several try/c...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/gora/pull/130


---