[GitHub] sijie commented on a change in pull request #531: Issue-530 BP-14 BP-14 Relax Durability - protocol changes preview

[gi...@git.apache.org]

sijie commented on a change in pull request #531: Issue-530 BP-14 BP-14 Relax Durability - protocol changes preview
URL: https://github.com/apache/bookkeeper/pull/531#discussion_r142500419
 
 

 ##########
 File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto
 ##########
 @@ -136,6 +143,13 @@ message GetBookieInfoRequest {
     optional int64 requested = 1;
 }
 
+message SyncRequest {
+    required int64 ledgerId = 1;
+    required bytes masterKey = 2;
+    required int64 firstEntryId = 3;
 
 Review comment:
   why do you need first and last entry ids?
   
   sync means flushing any outstanding requests and the response should tell you where does it sync to, no? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services