You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "Jacques Nadeau (JIRA)" <ji...@apache.org> on 2016/02/02 15:08:39 UTC

[jira] [Commented] (DRILL-4333) tests in Drill2489CallsAfterCloseThrowExceptionsTest fail in Java 8

    [ https://issues.apache.org/jira/browse/DRILL-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128285#comment-15128285 ] 

Jacques Nadeau commented on DRILL-4333:
---------------------------------------

Whomever picks this up need to fix the test. Overriding the new methods would likely break java 7 compatibility 

> tests in Drill2489CallsAfterCloseThrowExceptionsTest fail in Java 8
> -------------------------------------------------------------------
>
>                 Key: DRILL-4333
>                 URL: https://issues.apache.org/jira/browse/DRILL-4333
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Tools, Build & Test
>    Affects Versions: 1.5.0
>            Reporter: Deneche A. Hakim
>             Fix For: Future
>
>
> The following tests fail in Java 8:
> {noformat}
> Drill2489CallsAfterCloseThrowExceptionsTest.testClosedPlainStatementMethodsThrowRight
> Drill2489CallsAfterCloseThrowExceptionsTest.testclosedPreparedStmtOfOpenConnMethodsThrowRight
> Drill2489CallsAfterCloseThrowExceptionsTest.testClosedResultSetMethodsThrowRight1
> Drill2489CallsAfterCloseThrowExceptionsTest.testClosedResultSetMethodsThrowRight2
> Drill2489CallsAfterCloseThrowExceptionsTest.testClosedDatabaseMetaDataMethodsThrowRight
> Drill2769UnsupportedReportsUseSqlExceptionTest.testPreparedStatementMethodsThrowRight
> Drill2769UnsupportedReportsUseSqlExceptionTest.testPlainStatementMethodsThrowRight
> {noformat}
> Drill has special implementations of Statement, PreparedStatement, ResultSet and DatabaseMetadata that overrides all parent methods to make sure they throw a proper exception if the statement has already been closed. 
> These tests use reflection to make sure all methods behave correctly, but Java 8 added more methods that need to be properly overridden.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)