[GitHub] [skywalking] sonatype-lift[bot] commented on a diff in pull request #9198: Add more entities for Zipkin to improve performance

[GitBox <gi...@apache.org>]

sonatype-lift[bot] commented on code in PR #9198:
URL: https://github.com/apache/skywalking/pull/9198#discussion_r894190617


##########
oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/dao/H2ZipkinQueryDAO.java:
##########
@@ -201,45 +252,6 @@ public List<List<Span>> getTraces(final Set<String> traceIds) throws IOException

Review Comment:
   *[SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING](https://find-sec-bugs.github.io/bugs.htm#SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING):*  A prepared statement is generated from a nonconstant String in org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2ZipkinQueryDAO.getTraces(QueryRequest)
   
   Reply with *"**@sonatype-lift help**"* for more info.
   Reply with *"**@sonatype-lift ignore**"* to tell Liftbot to leave out the above finding from this PR.
   Reply with *"**@sonatype-lift ignoreall**"* to tell Liftbot to leave out all the findings from this PR and from the status bar in Github.
   
   When talking to Liftbot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about Liftbot commands.
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=276280288&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=276280288&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=276280288&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=276280288&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=276280288&lift_comment_rating=5) ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org