You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/16 03:06:31 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12070: fix: improve import flow UI/UX

codecov-io edited a comment on pull request #12070:
URL: https://github.com/apache/incubator-superset/pull/12070#issuecomment-745732251


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12070?src=pr&el=h1) Report
   > Merging [#12070](https://codecov.io/gh/apache/incubator-superset/pull/12070?src=pr&el=desc) (8ca0471) into [master](https://codecov.io/gh/apache/incubator-superset/commit/12e086dc616440b5edb96ccfec837a8f5eabcffb?el=desc) (12e086d) will **decrease** coverage by `2.53%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12070/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12070?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12070      +/-   ##
   ==========================================
   - Coverage   66.57%   64.04%   -2.54%     
   ==========================================
     Files         956      474     -482     
     Lines       46859    29273   -17586     
     Branches     4590        0    -4590     
   ==========================================
   - Hits        31198    18747   -12451     
   + Misses      15535    10526    -5009     
   + Partials      126        0     -126     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `64.04% <ø> (-0.47%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12070?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `58.62% <0.00%> (-34.24%)` | :arrow_down: |
   | [superset/datasets/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhwb3J0LnB5) | `78.72% <0.00%> (-15.40%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.78% <0.00%> (-5.75%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.90% <0.00%> (-2.99%)` | :arrow_down: |
   | ... and [493 more](https://codecov.io/gh/apache/incubator-superset/pull/12070/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12070?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12070?src=pr&el=footer). Last update [12e086d...8ca0471](https://codecov.io/gh/apache/incubator-superset/pull/12070?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org