You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "alekseyolg (via GitHub)" <gi...@apache.org> on 2023/06/28 16:39:37 UTC

[GitHub] [superset] alekseyolg commented on a diff in pull request #24534: build(docker): add dockerize image

alekseyolg commented on code in PR #24534:
URL: https://github.com/apache/superset/pull/24534#discussion_r1245490524


##########
dockerize.Dockerfile:
##########
@@ -0,0 +1,14 @@
+FROM alpine:latest
+
+ARG DOCKERIZE_VERSION=v0.6.1

Review Comment:
   @craig-rueda I don't understand what you mean by "official". I found only this repository on dockerhub (on the attached image). The youngest image from there is 4 years old. If I did not find a link to some official image, then I would be grateful if you show it to me, and I, in turn, could study this issue.
   
   About the busybox image: dockereze requires openssl to work, and busybox  doesn't have a package manager to install it, so in my opinion the best way is to use the alpine base image.
   ![image](https://github.com/apache/superset/assets/86011874/b6a204ef-b5ae-42b8-bf2e-36a121ad52af)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org