You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Li Zhiming (Code Review)" <ge...@cloudera.org> on 2020/08/04 04:29:14 UTC
[kudu-CR] [java] add state in ScanRequest toString
Li Zhiming has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16281
Change subject: [java] add state in ScanRequest toString
......................................................................
[java] add state in ScanRequest toString
Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Signed-off-by: Li Zhiming <li...@thinkingdata.cn>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/16281/1
--
To view, visit http://gerrit.cloudera.org:8080/16281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Gerrit-Change-Number: 16281
Gerrit-PatchSet: 1
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
[kudu-CR] [java] add state in ScanRequest toString
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [java] add state in ScanRequest toString
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Gerrit-Change-Number: 16281
Gerrit-PatchSet: 2
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Li Zhiming <li...@thinkingdata.cn>
[kudu-CR] [java] add state in ScanRequest toString
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16281 )
Change subject: [java] add state in ScanRequest toString
......................................................................
Patch Set 2: Verified+1
unrelated build failure (TSAN):
21:36:47 CMake Error at CMakeLists.txt:797 (file):
21:36:47 file COPY cannot copy file
21:36:47 "/home/jenkins-slave/workspace/kudu-master/2/src/kudu/client/../scripts/first_argument.sh"
21:36:47 to
21:36:47 "/home/jenkins-slave/workspace/kudu-master/2/build/tsan/bin/testdata/first_argument.sh":
--
To view, visit http://gerrit.cloudera.org:8080/16281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Gerrit-Change-Number: 16281
Gerrit-PatchSet: 2
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Comment-Date: Thu, 06 Aug 2020 04:39:52 +0000
Gerrit-HasComments: No
[kudu-CR] [java] add state in ScanRequest toString
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16281 )
Change subject: [java] add state in ScanRequest toString
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Gerrit-Change-Number: 16281
Gerrit-PatchSet: 2
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Comment-Date: Thu, 06 Aug 2020 04:42:16 +0000
Gerrit-HasComments: No
[kudu-CR] [java] add state in ScanRequest toString
Posted by "Li Zhiming (Code Review)" <ge...@cloudera.org>.
Li Zhiming has posted comments on this change. ( http://gerrit.cloudera.org:8080/16281 )
Change subject: [java] add state in ScanRequest toString
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16281/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16281/2//COMMIT_MSG@7
PS2, Line 7: [java] add state in ScanRequest toString
> I am curious about the motivation for this change. What do you want the sta
I encountered some scan expiring problems(posted in slack). Just want to know more detail about the request in the log.
--
To view, visit http://gerrit.cloudera.org:8080/16281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Gerrit-Change-Number: 16281
Gerrit-PatchSet: 2
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Comment-Date: Thu, 06 Aug 2020 03:10:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] add state in ScanRequest toString
Posted by "Li Zhiming (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16281
to look at the new patch set (#2).
Change subject: [java] add state in ScanRequest toString
......................................................................
[java] add state in ScanRequest toString
Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Signed-off-by: Li Zhiming <li...@thinkingdata.cn>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/16281/2
--
To view, visit http://gerrit.cloudera.org:8080/16281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Gerrit-Change-Number: 16281
Gerrit-PatchSet: 2
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] add state in ScanRequest toString
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16281 )
Change subject: [java] add state in ScanRequest toString
......................................................................
[java] add state in ScanRequest toString
Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Signed-off-by: Li Zhiming <li...@thinkingdata.cn>
Reviewed-on: http://gerrit.cloudera.org:8080/16281
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Gerrit-Change-Number: 16281
Gerrit-PatchSet: 3
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Li Zhiming <li...@thinkingdata.cn>
[kudu-CR] [java] add state in ScanRequest toString
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16281 )
Change subject: [java] add state in ScanRequest toString
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16281/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16281/2//COMMIT_MSG@7
PS2, Line 7: [java] add state in ScanRequest toString
I am curious about the motivation for this change. What do you want the state in the toString method for?
--
To view, visit http://gerrit.cloudera.org:8080/16281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b90c8352eb36406663a0a60041462a57ffde76
Gerrit-Change-Number: 16281
Gerrit-PatchSet: 2
Gerrit-Owner: Li Zhiming <li...@thinkingdata.cn>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 04 Aug 2020 15:48:24 +0000
Gerrit-HasComments: Yes