You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@toree.apache.org by GitBox <gi...@apache.org> on 2020/01/09 20:39:30 UTC

[GitHub] [incubator-toree] lresende commented on issue #180: [TOREE-508] Reply errors to iopub.error instead of iopub.exec_result

lresende commented on issue #180: [TOREE-508] Reply errors to iopub.error instead of iopub.exec_result
URL: https://github.com/apache/incubator-toree/pull/180#issuecomment-572744750
 
 
   I believe we are going in the right direction here, but with the change on behavior the errors are not completely showing up on the notebook interface.
   
   Original behavior:
   ![toree-508-original](https://user-images.githubusercontent.com/382917/72102913-e9819900-32dc-11ea-803d-4175c986128a.png)
   
   And with the changes from this pr:
   ![toree-508-updated](https://user-images.githubusercontent.com/382917/72102929-f30b0100-32dc-11ea-8262-93ea5c7646e6.png)
   
   As shown in the picture above, the contents are not all there, and the cell is not scrollable anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services