You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/06/28 22:41:23 UTC
Review Request 67776: Added per Framework Calls to metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
Bugs: MESOS-8843
https://issues.apache.org/jira/browse/MESOS-8843
Repository: mesos
Description
-------
This patch adds master metrics which count all scheduler call types,
for each framework which registers with the master.
Diffs
-----
src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67776/diff/1/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67776: Added per Framework Calls to metrics.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/#review205544
-----------------------------------------------------------
src/master/metrics.cpp
Lines 566 (patched)
<https://reviews.apache.org/r/67776/#comment288437>
Nice!
src/master/metrics.cpp
Lines 595 (patched)
<https://reviews.apache.org/r/67776/#comment288438>
Should we add a CHECK here making sure that `call_types` contains `callType`?
- Gastón Kleiman
On June 28, 2018, 3:41 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67776/
> -----------------------------------------------------------
>
> (Updated June 28, 2018, 3:41 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
>
>
> Bugs: MESOS-8843
> https://issues.apache.org/jira/browse/MESOS-8843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds master metrics which count all scheduler call types,
> for each framework which registers with the master.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67776/diff/1/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67776: Added per-framework metrics for scheduler
calls.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/#review206225
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On July 17, 2018, 6:42 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67776/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 6:42 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
>
>
> Bugs: MESOS-8843
> https://issues.apache.org/jira/browse/MESOS-8843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for scheduler calls.
>
>
> Diffs
> -----
>
> src/master/http.cpp c855de1b7bb71cb455d111fcd71c4486f421f2c2
> src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67776/diff/6/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67776: Added per-framework metrics for scheduler
calls.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/
-----------------------------------------------------------
(Updated July 20, 2018, 8:55 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
Bugs: MESOS-8843
https://issues.apache.org/jira/browse/MESOS-8843
Repository: mesos
Description
-------
Added per-framework metrics for scheduler calls.
Diffs (updated)
-----
src/master/http.cpp c855de1b7bb71cb455d111fcd71c4486f421f2c2
src/master/master.cpp 2af976f7ea7f81d4b06a45ce13286dbd61b9b144
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67776/diff/7/
Changes: https://reviews.apache.org/r/67776/diff/6-7/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67776: Added per-framework metrics for scheduler
calls.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/
-----------------------------------------------------------
(Updated July 18, 2018, 1:42 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
Bugs: MESOS-8843
https://issues.apache.org/jira/browse/MESOS-8843
Repository: mesos
Description
-------
Added per-framework metrics for scheduler calls.
Diffs (updated)
-----
src/master/http.cpp c855de1b7bb71cb455d111fcd71c4486f421f2c2
src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67776/diff/6/
Changes: https://reviews.apache.org/r/67776/diff/5-6/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67776: Added per-framework metrics for scheduler
calls.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/
-----------------------------------------------------------
(Updated July 18, 2018, 1:34 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
Bugs: MESOS-8843
https://issues.apache.org/jira/browse/MESOS-8843
Repository: mesos
Description
-------
Added per-framework metrics for scheduler calls.
Diffs (updated)
-----
src/master/http.cpp c855de1b7bb71cb455d111fcd71c4486f421f2c2
src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67776/diff/5/
Changes: https://reviews.apache.org/r/67776/diff/4-5/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67776: Added per-framework metrics for scheduler
calls.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/
-----------------------------------------------------------
(Updated July 9, 2018, 6:34 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
Bugs: MESOS-8843
https://issues.apache.org/jira/browse/MESOS-8843
Repository: mesos
Description
-------
Added per-framework metrics for scheduler calls.
Diffs (updated)
-----
src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67776/diff/4/
Changes: https://reviews.apache.org/r/67776/diff/3-4/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67776: Added per-framework metrics for scheduler
calls.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/#review205819
-----------------------------------------------------------
Ship it!
I think that it would be nicer to wrap all the non-lazy initialization/cleanup in an `EnumCounter` class, but we can do that in separate patch.
- Gastón Kleiman
On July 6, 2018, 11:56 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67776/
> -----------------------------------------------------------
>
> (Updated July 6, 2018, 11:56 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
>
>
> Bugs: MESOS-8843
> https://issues.apache.org/jira/browse/MESOS-8843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework metrics for scheduler calls.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67776/diff/3/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 67776: Added per-framework metrics for scheduler
calls.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/
-----------------------------------------------------------
(Updated July 6, 2018, 6:56 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
Bugs: MESOS-8843
https://issues.apache.org/jira/browse/MESOS-8843
Repository: mesos
Description
-------
Added per-framework metrics for scheduler calls.
Diffs (updated)
-----
src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67776/diff/3/
Changes: https://reviews.apache.org/r/67776/diff/2-3/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67776: Added per-framework metrics for scheduler
calls.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/
-----------------------------------------------------------
(Updated July 6, 2018, 6:32 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
Bugs: MESOS-8843
https://issues.apache.org/jira/browse/MESOS-8843
Repository: mesos
Description (updated)
-------
Added per-framework metrics for scheduler calls.
Diffs (updated)
-----
src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67776/diff/2/
Changes: https://reviews.apache.org/r/67776/diff/1-2/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67776: Added per-framework metrics for scheduler
calls.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/
-----------------------------------------------------------
(Updated July 6, 2018, 6:06 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
Summary (updated)
-----------------
Added per-framework metrics for scheduler calls.
Bugs: MESOS-8843
https://issues.apache.org/jira/browse/MESOS-8843
Repository: mesos
Description
-------
This patch adds master metrics which count all scheduler call types,
for each framework which registers with the master.
Diffs
-----
src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/67776/diff/1/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 67776: Added per Framework Calls to metrics.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/#review205543
-----------------------------------------------------------
Ship it!
src/master/metrics.cpp
Lines 566 (patched)
<https://reviews.apache.org/r/67776/#comment288436>
Ah! Awesome!
- Gilbert Song
On June 28, 2018, 3:41 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67776/
> -----------------------------------------------------------
>
> (Updated June 28, 2018, 3:41 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
>
>
> Bugs: MESOS-8843
> https://issues.apache.org/jira/browse/MESOS-8843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds master metrics which count all scheduler call types,
> for each framework which registers with the master.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/67776/diff/1/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>