You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "Andrus Adamchik (JIRA)" <ji...@apache.org> on 2012/10/28 16:37:12 UTC
[jira] [Updated] (CAY-197) boolean assignments in DataTypeSpec.java
[ https://issues.apache.org/jira/browse/CAY-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrus Adamchik updated CAY-197:
--------------------------------
Component/s: (was: Core Library)
> boolean assignments in DataTypeSpec.java
> ----------------------------------------
>
> Key: CAY-197
> URL: https://issues.apache.org/jira/browse/CAY-197
> Project: Cayenne
> Issue Type: Improvement
> Affects Versions: 1.1 [LEGACY]
> Environment: java source, all environments
> Reporter: Jason Dwyer
> Assignee: Andrus Adamchik
> Priority: Minor
> Attachments: ASF.LICENSE.NOT.GRANTED--data_type_spec.patch
>
>
> the assignment of boolean values for isStringType..etc is a little awkward, and using eclipse the IDE righly complains that a possible assignment in place of a comparison.
> assigning them when declaring the variables makes more sense.
> i'll work out how to attach a patch which refactors the declarations and the block(s) of if statements.
> its trivial, but makes it a little easier to follow ( and eclipse/compiler doesnt complain...:) )
> j
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira