You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/16 12:50:00 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4251: Issue about load balance of gRPC

wu-sheng commented on a change in pull request #4251: Issue about load balance of gRPC
URL: https://github.com/apache/skywalking/pull/4251#discussion_r367397245
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/StandardChannelBuilder.java
 ##########
 @@ -30,6 +31,10 @@
 
     @Override public ManagedChannelBuilder build(ManagedChannelBuilder managedChannelBuilder) throws Exception {
         return managedChannelBuilder.nameResolverFactory(new DnsNameResolverProvider())
+            /**
+             * It seems the code above can only work for low gRPC version.
 
 Review comment:
   We don't need to describe the history.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services