You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/10/04 23:03:49 UTC
[GitHub] betodealmeida opened a new pull request #6038: Fixes to the
CategoricalDeckGLContainer and filter box
betodealmeida opened a new pull request #6038: Fixes to the CategoricalDeckGLContainer and filter box
URL: https://github.com/apache/incubator-superset/pull/6038
This PR fixes a few bugs with the `CategoricalDeckGLContainer` and the filter box:
1. When the filter box dropdown is not a multi-select (like the time grain selector, where only a single value can be selected), `selectedValues[key]` is not an array, like the code currently assumes. I added logic to handle this.
2. When running the time slider, the `payload.data` was being filtered **inplace** for each time step, becoming empty after the first one. I changed the logic so we create a copy of the payload and pass that to `getLayer` instead.
3. The categories on the legend are computed from the props, and were being reset at every interaction. I changed the logic so `state.categories` is preserved when props change. Not sure if this is the best way to do this. (@kristw, @xtinec?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org