You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/10 17:20:44 UTC
[GitHub] [arrow-rs] bjchambers opened a new pull request #939: implement take kernel for null arrays
bjchambers opened a new pull request #939:
URL: https://github.com/apache/arrow-rs/pull/939
# Which issue does this PR close?
Closes #938 .
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #939: implement take kernel for null arrays
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #939:
URL: https://github.com/apache/arrow-rs/pull/939#issuecomment-965578087
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/939?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#939](https://codecov.io/gh/apache/arrow-rs/pull/939?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1214341) into [master](https://codecov.io/gh/apache/arrow-rs/commit/1945f6f96551e501010a4578295456a1f9f335e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1945f6f) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #939 +/- ##
=======================================
Coverage 82.34% 82.35%
=======================================
Files 168 168
Lines 48520 48541 +21
=======================================
+ Hits 39955 39976 +21
Misses 8565 8565
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow-rs/pull/939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy90YWtlLnJz) | `95.22% <100.00%> (+0.14%)` | :arrow_up: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.52% <0.00%> (-0.20%)` | :arrow_down: |
| [arrow/src/error.rs](https://codecov.io/gh/apache/arrow-rs/pull/939/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2Vycm9yLnJz) | `15.55% <0.00%> (+2.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/939?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/939?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1945f6f...1214341](https://codecov.io/gh/apache/arrow-rs/pull/939?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #939: implement take kernel for null arrays
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #939:
URL: https://github.com/apache/arrow-rs/pull/939#discussion_r747002058
##########
File path: arrow/src/compute/kernels/take.rs
##########
@@ -1813,6 +1824,38 @@ mod tests {
.unwrap();
}
+ #[test]
+ fn test_null_array_smaller_than_indices() {
+ let values = NullArray::new(2);
+ let indices = UInt32Array::from(vec![Some(0), None, Some(15)]);
+
+ let result = take(&values, &indices, None).unwrap();
+ let expected: ArrayRef = Arc::new(NullArray::new(3));
+ assert_eq!(&result, &expected);
+ }
+
+ #[test]
+ fn test_null_array_larger_than_indices() {
+ let values = NullArray::new(5);
+ let indices = UInt32Array::from(vec![Some(0), None, Some(15)]);
+
+ let result = take(&values, &indices, None).unwrap();
+ let expected: ArrayRef = Arc::new(NullArray::new(3));
+ assert_eq!(&result, &expected);
+ }
+
+ #[test]
+ fn test_null_array_indices_out_of_bounds() {
Review comment:
π for this test -- I was going to say something about validating bounds of the take indexes but this covers it. π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #939: implement take kernel for null arrays
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #939:
URL: https://github.com/apache/arrow-rs/pull/939#issuecomment-966237959
Thanks again @bjchambers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #939: implement take kernel for null arrays
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #939:
URL: https://github.com/apache/arrow-rs/pull/939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org