You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "tflobbe (via GitHub)" <gi...@apache.org> on 2023/05/05 20:53:56 UTC
[GitHub] [solr] tflobbe opened a new pull request, #1628: SOLR-16789: Admin UI Dashboard shows "unauthenticated" warning on authenticated servers
tflobbe opened a new pull request, #1628:
URL: https://github.com/apache/solr/pull/1628
I'm not sure this is the right fix, I don't trust my UI skills. I believe this was introduced in https://github.com/apache/solr/pull/1296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #1628: SOLR-16789: Admin UI Dashboard shows "unauthenticated" warning on authenticated servers
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #1628:
URL: https://github.com/apache/solr/pull/1628#discussion_r1186499328
##########
solr/webapp/web/js/angular/controllers/index.js:
##########
@@ -29,6 +29,10 @@ solrAdminApp.controller('IndexController', function($scope, System, Cores, Const
sessionStorage.setItem("auth.username", data.security.username);
}
+ if ("authenticationPlugin" in data.security && data.security.authenticationPlugin != null) {
Review Comment:
I'd have to see if we ahve an established pattern for these if's! `if data.security.authenticationPlugin ` migth work...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] tflobbe commented on a diff in pull request #1628: SOLR-16789: Admin UI Dashboard shows "unauthenticated" warning on authenticated servers
Posted by "tflobbe (via GitHub)" <gi...@apache.org>.
tflobbe commented on code in PR #1628:
URL: https://github.com/apache/solr/pull/1628#discussion_r1186502126
##########
solr/webapp/web/js/angular/controllers/index.js:
##########
@@ -29,6 +29,10 @@ solrAdminApp.controller('IndexController', function($scope, System, Cores, Const
sessionStorage.setItem("auth.username", data.security.username);
}
+ if ("authenticationPlugin" in data.security && data.security.authenticationPlugin != null) {
Review Comment:
Yes, that worked for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] tflobbe commented on pull request #1628: SOLR-16789: Admin UI Dashboard shows "unauthenticated" warning on authenticated servers
Posted by "tflobbe (via GitHub)" <gi...@apache.org>.
tflobbe commented on PR #1628:
URL: https://github.com/apache/solr/pull/1628#issuecomment-1536816094
Ran these steps:
`gw clean -p solr/packaging dev && cd solr/packaging/build/dev`
`bin/solr start -e cloud -noprompt`
Checked that the warning was present in the dashboard
`bin/solr auth enable -credentials foo:bar -z localhost:9983`
On `main`, the warning is still present. With the patch I get:
<img width="947" alt="Screenshot 2023-05-05 at 2 38 27 PM" src="https://user-images.githubusercontent.com/496684/236573661-6672f90c-5f10-4afd-85c9-8e4a9fe5d4a8.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] tflobbe merged pull request #1628: SOLR-16789: Admin UI Dashboard shows "unauthenticated" warning on authenticated servers
Posted by "tflobbe (via GitHub)" <gi...@apache.org>.
tflobbe merged PR #1628:
URL: https://github.com/apache/solr/pull/1628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org