[jira] [Commented] (OAK-6111) update maven-scr-plugin

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990625#comment-15990625 ] 

Chetan Mehrotra commented on OAK-6111:
--------------------------------------

bq.  changing the logic would introduce bigger compatibility issues

We can use approach similar to what Robert suggested. 

# Define a new "oak.security.name" property and modify existing components to have this name property defined
# Change the logic in  SecurityProviderRegistration to look for 
## First with new name property
## Fallback to "service.pid" property

For older code where bundle is already published using older scr plugin the "service.pid" property would be present (its a build time change in behaviour) and would get used. And for newer code/builds the logic would look up the new property. This should allow us to remain backward compatible and also move to new scr plugin.

> update maven-scr-plugin
> -----------------------
>
>                 Key: OAK-6111
>                 URL: https://issues.apache.org/jira/browse/OAK-6111
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: parent
>            Reporter: Julian Reschke
>             Fix For: 1.8
>
>         Attachments: org.apache.jackrabbit.oak.run.osgi.JaasConfigSpiTest.txt, unit-tests.log, unit-tests.log
>
>
> Updating maven-scr-plugin to 1.24.0 causes subsequent failures in oak-pojo-sr.
> It seems we also need to update felix components, and add org.apache.felix.scr.compat, but even with that, I still get test failures.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)