You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/08/20 16:20:47 UTC
[GitHub] [trafficserver] randall commented on a change in pull request #8262: Align strategies.yaml load logging with other config files
randall commented on a change in pull request #8262:
URL: https://github.com/apache/trafficserver/pull/8262#discussion_r693068312
##########
File path: proxy/http/remap/NextHopStrategyFactory.cc
##########
@@ -220,9 +236,6 @@ NextHopStrategyFactory::loadConfigFile(const std::string &fileName, std::strings
std::ifstream file(fileName + "/" + i.data());
if (file.is_open()) {
while (std::getline(file, line)) {
- if (line[0] == '#') {
- // continue;
Review comment:
I removed it because the continue wall was commented out. It looked like it was nothing.
##########
File path: proxy/http/remap/NextHopStrategyFactory.cc
##########
@@ -220,9 +236,6 @@ NextHopStrategyFactory::loadConfigFile(const std::string &fileName, std::strings
std::ifstream file(fileName + "/" + i.data());
if (file.is_open()) {
while (std::getline(file, line)) {
- if (line[0] == '#') {
- // continue;
Review comment:
I removed it because the continue was was commented out. It looked like it was nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org