You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/26 17:21:15 UTC
[GitHub] [arrow] lafiona opened a new pull request #9585: ARROW-11795: [MATLAB] Migrate MATLAB Interface for Apache Arrow design doc to Markdown
lafiona opened a new pull request #9585:
URL: https://github.com/apache/arrow/pull/9585
Upload MATLAB Interface for Apache Arrow design document to `matlab/doc/` to be archived with the code.
The discussion about the design document can be found here: https://lists.apache.org/thread.html/r7ac793613892487f60f080de0bc8bab6a27b3ae18e4c47b572e2649f%40%3Cdev.arrow.apache.org%3E
**Note**: the design document contains a SVG image that is currently hosted in a separate repository (https://github.com/mathworks/matlab-arrow-support-files). It seems like it would be preferable to have this live directly within the Apache Arrow project, alongside the code, in `matlab/doc/images/`, however we are not sure if it is acceptable to commit an image file. The image is an SVG file which should be more amenable to version control (it is only 37 kb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lafiona commented on pull request #9585: ARROW-11795: [MATLAB] Migrate MATLAB Interface for Apache Arrow design doc to Markdown
Posted by GitBox <gi...@apache.org>.
lafiona commented on pull request #9585:
URL: https://github.com/apache/arrow/pull/9585#issuecomment-793006219
Just checking in on the state of this pull request, I fully recognize that there is a large backlog of open requests and it must be a challenge to manage all the contributions. However, I wanted to ask if there is anything I can do to simplify the process for reviewers.
I noticed that one of the CI checks failed, but I do not think it is related to the change in this request. Please let me know if there is any action I need to take.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #9585: ARROW-11795: [MATLAB] Migrate MATLAB Interface for Apache Arrow design doc to Markdown
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #9585:
URL: https://github.com/apache/arrow/pull/9585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #9585: ARROW-11795: [MATLAB] Migrate MATLAB Interface for Apache Arrow design doc to Markdown
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9585:
URL: https://github.com/apache/arrow/pull/9585#issuecomment-816838502
@lafiona If you could accept the change I proposed, CI should pass and I will merge this. Thanks for your patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #9585: ARROW-11795: [MATLAB] Migrate MATLAB Interface for Apache Arrow design doc to Markdown
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9585:
URL: https://github.com/apache/arrow/pull/9585#discussion_r610788093
##########
File path: matlab/doc/matlab_interface_for_apache_arrow_design.md
##########
@@ -0,0 +1,347 @@
+# MATLAB Interface for Apache Arrow
Review comment:
The CI failure is that this file needs the apache license header: https://github.com/apache/arrow/pull/9585/checks?check_run_id=1989365727#step:7:872
```suggestion
<!---
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
# MATLAB Interface for Apache Arrow
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9585: ARROW-11795: [MATLAB] Migrate MATLAB Interface for Apache Arrow design doc to Markdown
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9585:
URL: https://github.com/apache/arrow/pull/9585#issuecomment-786794420
https://issues.apache.org/jira/browse/ARROW-11795
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lafiona commented on pull request #9585: ARROW-11795: [MATLAB] Migrate MATLAB Interface for Apache Arrow design doc to Markdown
Posted by GitBox <gi...@apache.org>.
lafiona commented on pull request #9585:
URL: https://github.com/apache/arrow/pull/9585#issuecomment-816868396
@nealrichardson Thank you for reviewing this and making the necessary change! I will add the Apache license header to all future files I submit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org