You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2016/10/12 00:40:26 UTC
[GitHub] cordova-android pull request #341: add message, catch exception if require f...
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-android/pull/341
add message, catch exception if require fails
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
android
### What does this PR do?
catches possible error and outputs message
### What testing has been done on this change?
jshint, ran tests
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-android CB-11999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/341.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #341
----
commit 7862a82e95ad6ceacb0f69c0ba7b6ba84db4cc68
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2016-10-12T00:19:10Z
add message, catch exception if require fails
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #341: CB-11999 add message, catch exception if require...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-android/pull/341
LGTM. Whomever pulls this in, make sure to squash, amend the commit with the JIRA issue number
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #341: CB-11999 add message, catch exception if require...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/341
## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/341?src=pr) is 35.31% (diff: 0.00%)
> Merging [#341](https://codecov.io/gh/apache/cordova-android/pull/341?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will decrease coverage by **0.34%**
```diff
@@ master #341 diff @@
==========================================
Files 12 12
Lines 1015 1025 +10
Methods 200 200
Messages 0 0
Branches 168 168
==========================================
Hits 362 362
- Misses 653 663 +10
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [2532c4a...7862a82](https://codecov.io/gh/apache/cordova-android/compare/2532c4a39e9ec96aaa573c8fa54d48507019fcc7...7862a82e95ad6ceacb0f69c0ba7b6ba84db4cc68?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #341: CB-11999 add message, catch exception if ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/341
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org