You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Madhuka <gi...@git.apache.org> on 2015/07/12 21:01:33 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
GitHub user Madhuka opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/152
ZEPPELIN-157: Adding Map Visualization for Zeppelin
- [x] Listing Map charting Libraries
- [x] Checking compatible license
- [x] Adding chart library (leafletjs)
- [x] Adding new button for chart mapping
- [x] Loading GIS Mapp in Zeppelin
- [ ] Adding sample data set (loading)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Madhuka/incubator-zeppelin milestone05-map
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit 497962eb1520824aeffd09198ef71920b0c903fe
Author: madhuka <ma...@gmail.com>
Date: 2015-07-12T17:35:17Z
Adding leaflet for map
commit f453325ec3bbf66a231b89ac09f9c5096e11c92f
Author: madhuka <ma...@gmail.com>
Date: 2015-07-12T18:08:08Z
Adding mapping for UI
commit e65d829e1c7e0222eb23bb873e5be1b4cf58f1c0
Author: madhuka <ma...@gmail.com>
Date: 2015-07-12T18:55:02Z
Adding map chart for zeppelin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-163109428
@randerzander: Thanks for ping!
@bzz : I will create new PR for adding leaflet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-133631065
@eranwitkon It is been fixed few days ago. Please update your copy.
Now there is data validator. So when you pass 1 column test will fail. Since Zeppelin currently doesn't have notifications you will not see any messages in UI as notification. But the error messages will be printed on the console. Please see that. (There is a separate PR for notifications.)
Further if you are interested about data validator visit the documentation. #203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-127289349
Data validator message will contain {'error':true/false,'msg':'error msg'}.
Data schema can be set as config file.
Data validator is expose as service and it is extendable (factory model).
Here is current screen shoot of PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-163121874
@corneadoug : Thanks, get #262, it contain data validation.
So new PR will have only Map Vis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131438629
Hi,
I tried testing your PR (152) but I could not see the map icon on the output page.
Did I miss something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by randerzander <gi...@git.apache.org>.
Github user randerzander commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-163108454
@Madhuka @bzz what's holding this one up? Is there something someone else can do to get this across the goal line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-144279599
@bzz : I have build PR for data validator. At the same time I will create new PR for leaflet mapping as lot of users are interested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by yanglei99 <gi...@git.apache.org>.
Github user yanglei99 commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-214961384
When will this be in the main stream？It is a pity to see some great function missing while the solution is already available for more than half a year. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by randerzander <gi...@git.apache.org>.
Github user randerzander commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-141191419
anything we can do to figure out the failing CI build issue? This feature is incredibly useful- will stop quite a lot of HTML and JS hacking for users
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-133525197
Did you see my comment from 5 days ago?
Now that I can run the code I found this behavior :
Try the following code:
%sql
select Name from myMap
where Country = "${Country='United States'}"
The data output of this one have only one column - name but when I press
the map icon I get it to show the data as before. (other view respect the
select and present it as expected)
Eran
בתאריך יום ו׳, 21 באוג׳ 2015, 21:17 מאת madhuka <no...@github.com>:
> CI Build is test with PR[1], It contain data validations (fully) and
> leaflet support with map and tutorial with squashing commits
>
> [1] #238 <https://github.com/apache/incubator-zeppelin/pull/238>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-133519842>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-139316805
@bzz : I have updated the PR to master. Build has run for multiple times, and any idea or reason to run build for multiple times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131522919
I don't think you missed anything if you have built it correctly. Please clear the browser cache.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131722364
The Build runs multiple time on the CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-122907779
Due to -len it is breaking
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-138777945
@bzz : Even after rebase CI is giving fail and CI build has run for two times last one is successful and first one is fail in zeppelin server test. (where is my commits are in zeppelin web and I have post my finding bout test in this PR)
any idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-133519842
CI Build is test with PR[1], It contain data validations (fully) and leaflet support with map and tutorial with squashing commits
[1] https://github.com/apache/incubator-zeppelin/pull/238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by ankurmitujjain <gi...@git.apache.org>.
Github user ankurmitujjain commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-207395845
@Madhuka Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-214997716
Referee #765
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-138777014
@bzz : PR is re-based and local build fine and test also fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-164705767
@Madhuka Are you working on a new PR?
Tell me if you need some help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131800619
yes, Build has run multiple times and final build was successful according to log files. But there is still one failing check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-120754413
Map Visualization for Zeppelin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by ankurmitujjain <gi...@git.apache.org>.
Github user ankurmitujjain commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-181825058
Hi @Madhuka any update on this? really appreciate your effort for this.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-163109639
@randerzander @Madhuka
I'm reviewing #262 first, already took a look at it.
I'm planning on finishing review on those 3 PR this week.
But I think this will need a new PR without data validation and rebased at least.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-124595000
Loading sample data from internet
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-142812217
@bzz : ZeppelinIT which is failed in CI run fine in local environment. I have re-base (update) the PR. is there any more things to do for this PR?
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.zeppelin.ZeppelinIT
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.075 sec - in org.apache.zeppelin.ZeppelinIT
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- scalatest-maven-plugin:1.0:test (test) @ zeppelin-server ---
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-120789495
@vgmartinez
Thanks, Yes, I will make it dynamic
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-144279289
@datagiraffe : thanks for the interest
1. Current zeppelin is written on order_of_key level. It is not written to detected automatically at the moment.
2. key is local variable and it is not twice. And all the variable name can have issue. That is the reason 'jshint' in zeppelin. It is not reason to break.
breaking happen in build due to CI binding test. you can find the points in this thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by tog <gu...@gmail.com>.
hi Madhuka
I am looking forward testing it. Have you considered plotting trajectories
(lines between 2 points) and disks - and make this a default plots for
specific tables for example?
Cheers
Guillaume
On Monday, July 20, 2015, Madhuka <git@git.apache.org
<javascript:_e(%7B%7D,'cvml','git@git.apache.org');>> wrote:
> Github user Madhuka commented on the pull request:
>
>
> https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-122901099
>
> Add it as in tutorial, where it can be run from the clean environment
>
> 
>
> Loading sample GIS Data for tutorial
> 
>
> Makers looks like
> 
>
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
--
PGP KeyID: 2048R/EA31CFC9 subkeys.pgp.net
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-122901099
Add it as in tutorial, where it can be run from the clean environment
Loading sample GIS Data for tutorial
Makers looks like
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by datagiraffe <gi...@git.apache.org>.
Github user datagiraffe commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-144073107
Map Visualization for Zeppelin would be a great addition!
I've tried the code and ran into several problems.
I don't think it's good to select the lat and lon statically like so:
https://github.com/Madhuka/incubator-zeppelin/blob/milestone05-map/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L866
It would be nice if they were detected automatically. Maybe if there are columns lat, latitude, lon, long or longitude, pick them?
The same goes for the key:
https://github.com/Madhuka/incubator-zeppelin/blob/milestone05-map/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L863
If a key exists twice, it obviously breaks. Key and message are the same though, but I may be interested in the same message at different locations.
There should be a settings drop down like for the other chart types where this can be configured. With the current version, that doesn't seem to work. (Only for me?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-141852973
@randerzander thank you for bringing it to our attention!
So, it looks like selenium in-browser Integration Tests of Zeppelin Server submodule are failing here:
```
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.zeppelin.ZeppelinIT
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 68.171 sec <<< FAILURE! - in org.apache.zeppelin.ZeppelinIT
testAngularDisplay(org.apache.zeppelin.ZeppelinIT) Time elapsed: 67.963 sec <<< ERROR!
org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//div[@ng-controller=\"ParagraphCtrl\"][1]//div[@id=\"angularTestButton\"]"}
Command duration or timeout: 14 milliseconds
```
@Madhuka can you verify that it actually passes well please? (at first on your local env, by something like `mvn -am -pl zeppelin-server integration-test`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-215126055
Great - will you have time to get that ready then?
_____________________________
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-120761338
Hi @Madhuka....
when you try to resize the paragraph the map does not update to the new size ... I have seen that you have:
<leaflet width="100%" height="480px"></leaflet>
It is possible to do dynamic
thanks for you contributions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131391418
Test are added on data validation.
PR covers all the chart type data models in zeppelin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-180840046
any update on this? @Madhuka this would be very cool to have
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131536089
Cool that did the trick.
Now that I can run the code I found this behavior :
Try the following code:
%sql
select Name from myMap
where Country = "${Country='United States'}"
The data output of this one have only one column - name but when I press
the map icon I get it to show the data as before. (other view respect the
select and present it as expected)
Eran
On Sun, Aug 16, 2015 at 1:36 PM madhuka <no...@github.com> wrote:
> I don't think you missed anything if you have built it correctly. Please
> clear the browser cache.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-131522919>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-138859366
@buzz I will try to make both checks in green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-141870314
@bzz : I wil verify in my local env.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-125176472
In Data `validatorservices` will return error status in boolean true or false. And also it will return error msg with explanation which data record is not validated under data schema.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-138790015
`This branch has conflicts that must be resolved` signifies that it is not aligned with the latest master, you need to make sure both checks are green here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-214995913
Based on the earlier comment, are we moving to #728 then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-138760753
Shall we rebase it on latest master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by eddies <gi...@git.apache.org>.
Github user eddies commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-186458888
@corneadoug absolutely. As I mentioned in #728, I only made my PR out of expediency because I didn't see any movement here. If @Madhuka will be revisiting this PR soon, that would be ideal--he definitely deserves the credit for all his work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-132897074
The Travis CI is only check first Build only, isn't it? First build test failure which is bind to CI and In next build It was fine. According to log second build (final build) says "BUILD SUCCESS" in the log.
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [ 6.055 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [ 3.867 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [ 2.659 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [ 35.690 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [ 0.699 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [ 0.316 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [ 0.315 s]
[INFO] Zeppelin: Hive interpreter ......................... SUCCESS [ 3.282 s]
[INFO] Zeppelin: Apache Geode interpreter ................. SUCCESS [ 7.297 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [ 0.413 s]
[INFO] Zeppelin: Tajo interpreter ......................... SUCCESS [ 1.088 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [ 4.955 s]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [ 0.680 s]
[INFO] Zeppelin: Lens interpreter ......................... SUCCESS [ 2.181 s]
[INFO] Zeppelin: Cassandra ................................ SUCCESS [ 6.649 s]
[INFO] Zeppelin: web Application .......................... SUCCESS [ 37.351 s]
[INFO] Zeppelin: Server ................................... SUCCESS [ 18.031 s]
[INFO] Zeppelin: Packaging distribution ................... SUCCESS [ 26.737 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:39 min
[INFO] Finished at: 2015-08-17T05:10:28+00:00
[INFO] Final Memory: 56M/360M
[INFO] ------------------------------------------------------------------------
travis_time:end:2f3eec76:start=1439788067730573331,finish=1439788229232148013,duration=161501574682
[0K
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-157: Adding Map Visualiz...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-186336504
After discussion with @Madhuka, this should be rebased and finished by 1st week of March. (since he is busy)
There has been a new PR opened recently (#728), however I'd like Madhuka to finish his contribution for a few reasons:
* This PR was part of Google Summer of Code, and is all thats left of all the work Madhuka did, so it would be nice for him to get his contribution
* This PR has been around for quite some time, and I took way too long to properly review it
However if it is not done by then, we should get things moving and go with #728, @eddies fine with that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---