You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/09/12 16:27:22 UTC
[GitHub] couchdb-nmo pull request: fix docs
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-nmo/pull/4
fix docs
- fix broken documentation for commands
- back to 72 char limit for manpages / help in terminal
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-nmo prog-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-nmo/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit c30bb233eb8aee1922cce07deab555c3df61f2d1
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2015-09-12T14:26:13Z
fix docs
- fix broken documentation for commands
- back to 72 char limit for manpages / help in terminal
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: fix docs
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/4#issuecomment-142524588
+1. Thanks for fixing my help file mess. But I think limiting characters on the javascript files is unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: fix docs
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/4#issuecomment-142576194
yes, agreed @garren. the js change in `src/import-csv.js` was that the command is exported properly:
```diff
-export function importcsv (file, url, {delimiter= ',', columns= true}) {
+
+export default importcsv;
+function importcsv (file, url, {delimiter= ',', columns= true}) {
```
this makes the `nmo.commands.importcsv` available to users of the programmatic API.
the result is
` nmo.commands.importcsv` vs ` nmo.commands.importcsv.importcsv`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: fix docs
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-nmo/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-nmo pull request: fix docs
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-nmo/pull/4#issuecomment-144426627
merged as a8d0b23d70918945c622598622c3a3a78856df82
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---