You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/01/04 08:44:00 UTC
[jira] [Commented] (LUCENE-9642)
TestXYShapeEncoding.testRandomPolygonEncoding failure
[ https://issues.apache.org/jira/browse/LUCENE-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258067#comment-17258067 ]
ASF subversion and git services commented on LUCENE-9642:
---------------------------------------------------------
Commit ce667fdd2f9453f34c8dc393600565c425021fd1 in lucene-solr's branch refs/heads/master from Ignacio Vera
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ce667fd ]
LUCENE-9642: Rotate triangle points before checking triangle orientation (#2154)
When encoding triangles in ShapeField, make sure generated triangles are CCW by rotating triangle points before checking triangle orientation.
> TestXYShapeEncoding.testRandomPolygonEncoding failure
> -----------------------------------------------------
>
> Key: LUCENE-9642
> URL: https://issues.apache.org/jira/browse/LUCENE-9642
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Ignacio Vera
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This test fails for the following seed:
>
> {{./gradlew test --tests TestXYShapeEncoding.testRandomPolygonEncoding -Dtests.seed=CB4BC47404510050 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=ug -Dtests.timezone=America/Matamoros -Dtests.asserts=true -Dtests.file.encoding=UTF-8}}
>
> When encoding.a triangle we perform two actions:
> 1) Make sure that the orientation of the triangle is CCW
> 2) Place the point with minimum X in the first position so we might rotate the points in the triangle.
> In this case the triangle is degenerated so when the triangle is rotated, it changes the orientation, tripping an assertion when decoding it. I think the fix for this is to change the order of the actions above.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org