You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/21 17:52:55 UTC

[GitHub] [iceberg] CircArgs commented on a diff in pull request #4816: remove operations from base expressions; add in expression

CircArgs commented on code in PR #4816:
URL: https://github.com/apache/iceberg/pull/4816#discussion_r878743507


##########
python/src/iceberg/expressions/base.py:
##########
@@ -267,6 +204,34 @@ def __str__(self) -> str:
         return "false"
 
 
+class In(BooleanExpression):

Review Comment:
   I've made some changes based on your suggestions and creating `UnboundIn` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org