Re: [PR] fix(drill-detail): restrict page size selector to only valid option [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #37975:
URL: https://github.com/apache/superset/pull/37975#issuecomment-4427470630

   Hey @veeceey — took the liberty of rebasing this for you (your branch was 722 commits behind master and conflicting). Squashed your 8 commits into one with you preserved as author, then resolved the trivial test-file conflict (a `describe('download actions')` block landed on master in the same spot as your new `test('should render pagination …')`). Final shape is +54/-7 across the same 2 files; net behavior is unchanged from your last push.
   
   Heads-up since I force-pushed: your local branch will need a `git fetch && git reset --hard origin/fix/issue-36267-drill-detail-page-size` before your next push.
   
   Thanks for sticking with this PR through the rework — letting page-size choice actually work end-to-end is the right fix here. There's still one open codeant suggestion worth addressing if you have a minute: the regression test asserts the pagination component renders, but doesn't verify that `[5, 15, 25, 50, 100]` are all actually offered as choices. Tightening that would lock in the fix you just made. Otherwise this should be ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org